fix(windows): prefer Git Bash before PATH bash

[tt-a1i]

Summary

• move known Git-for-Windows install paths ahead of the generic shutil.which("bash") fallback in _find_bash()
• keep the existing higher priorities intact: HERMES_GIT_BASH_PATH first, then Hermes-managed PortableGit/MinGit
• add regression coverage for the native Windows case where PATH resolves bash to the WSL launcher while ProgramFiles\Git\bin\bash.exe exists

Fixes #47837.

Related PRs

This is narrower than #35675 and #38092:

• fix(terminal): prefer Scoop MSYS bash over WSL bash on Windows #35675 overlaps in the Windows bash area, but also changes cwd/file-operation behavior and does not narrowly restore ProgramFiles Git before PATH for [Bug]: _find_bash() resolves to WSL bash before checking system Git-for-Windows paths on Native Windows #47837.
• fix(windows): add Scoop, Chocolatey, and MSYS2 Git Bash paths #38092 adds more package-manager Git paths and is complementary; it does not move the existing known Git-for-Windows candidates before shutil.which("bash").

Testing

• $HOME/.hermes/hermes-agent/venv/bin/python -m pytest tests/tools/test_local_find_bash.py -q
• $HOME/.hermes/hermes-agent/venv/bin/python -m pytest tests/tools/test_local_env_cwd_recovery.py tests/tools/test_local_env_blocklist.py tests/tools/test_local_find_bash.py -q
• $HOME/.hermes/hermes-agent/venv/bin/python -m compileall -q tools/environments/local.py tests/tools/test_local_find_bash.py
• git diff --check

Review

A read-only subagent review found no blocking issues and confirmed this is an independent narrow fix for #47837, not a duplicate of #35675/#38092.

[tonydwb]

Code Review Summary

Verdict: Approved

Good fix for Windows Git Bash detection. The reordering in _find_bash() now prioritizes known Git-for-Windows installs (from Program Files) over shutil.which("bash"), which on Windows would often return the WSL launcher (C:\Windows\System32\bash.exe) instead of the actual Git Bash.

Looks Good

• Clear comment explaining the rationale for the reordering
• Tests added in a new file covering all four bash-finding priority cases
• No regression risk — fallback path remains intact

---

Reviewed by Hermes Agent

[teknium1]

Thanks for the focused Windows regression fix. This is already implemented on current main.

• tools/environments/local.py:584-598 now checks the known Git-for-Windows paths and returns a matching candidate before the shutil.which("bash") fallback.
• The matching change landed as ad5f3341d (fix(terminal): prefer Git for Windows bash over Linux bash on Windows) through PR fix(terminal): force Git for Windows bash + convert native CWD for bash cd #56384.
• It shipped in release v2026.7.1.
• The maintainer update on [Bug]: _find_bash() resolves to WSL bash before checking system Git-for-Windows paths on Native Windows #47837 also confirms PR fix(terminal): force Git for Windows bash + convert native CWD for bash cd #56384 fixed this exact WSL-shim resolution issue.

Automated hermes-sweeper review.