Skip to content

fix(desktop): keep clarify visible in silent tool mode - #47665

Closed
sanghyuk-seo-nexcube wants to merge 1 commit into
NousResearch:mainfrom
sanghyuk-seo-nexcube:fix/desktop-clarify-tool-progress-off
Closed

fix(desktop): keep clarify visible in silent tool mode#47665
sanghyuk-seo-nexcube wants to merge 1 commit into
NousResearch:mainfrom
sanghyuk-seo-nexcube:fix/desktop-clarify-tool-progress-off

Conversation

@sanghyuk-seo-nexcube

Copy link
Copy Markdown
Contributor

Summary

  • Emit clarify tool lifecycle events even when display.tool_progress is off, so the Desktop inline clarify UI has a pending tool row to mount on.
  • Keep ordinary tool lifecycle events hidden in silent mode.
  • Add regression coverage for both the clarify exception and the non-blocking silent-mode invariant.

Test Plan

  • python -m pytest tests/test_tui_gateway_server.py::test_clarify_lifecycle_emits_when_tool_progress_off tests/test_tui_gateway_server.py::test_non_blocking_tool_lifecycle_stays_hidden_when_tool_progress_off -q
  • python -m py_compile tui_gateway/server.py tests/test_tui_gateway_server.py
  • git diff --check

Notes

  • I also ran scripts/run_tests.sh tests/test_tui_gateway_server.py; the new tests passed, but the file run hit an unrelated local environment failure in test_browser_manage_connect_default_local_reports_launch_hint where the expected “No supported Chromium-family browser executable was found” launch-hint line was not present.

@alt-glitch alt-glitch added type/bug Something isn't working comp/tui Terminal UI (ui-tui/ + tui_gateway/) comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists duplicate This issue or pull request already exists labels Jun 17, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #47544 — both emit the clarify tool lifecycle (tool.start/tool.complete) when display.tool_progress=off while keeping ordinary tool events hidden, with near-identical regression tests in tests/test_tui_gateway_server.py. #47544 (opened ~4h earlier) is the broader fix: it also reconstructs a pending clarify row from clarify.request in apps/desktop use-message-stream.ts to cover the missed-tool.start reconnect/hydration race. Marking this as the narrower server-side subset; maintainer can pick whichever lands.

@sanghyuk-seo-nexcube
sanghyuk-seo-nexcube force-pushed the fix/desktop-clarify-tool-progress-off branch from 2b9ab4a to 277ce13 Compare June 17, 2026 05:48
@sanghyuk-seo-nexcube
sanghyuk-seo-nexcube deleted the fix/desktop-clarify-tool-progress-off branch July 2, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery comp/tui Terminal UI (ui-tui/ + tui_gateway/) duplicate This issue or pull request already exists P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants