fix(desktop): keep clarify visible in silent tool mode - #47665
Closed
sanghyuk-seo-nexcube wants to merge 1 commit into
Closed
fix(desktop): keep clarify visible in silent tool mode#47665sanghyuk-seo-nexcube wants to merge 1 commit into
sanghyuk-seo-nexcube wants to merge 1 commit into
Conversation
Collaborator
|
Duplicate of #47544 — both emit the |
sanghyuk-seo-nexcube
force-pushed
the
fix/desktop-clarify-tool-progress-off
branch
from
June 17, 2026 05:48
2b9ab4a to
277ce13
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
clarifytool lifecycle events even whendisplay.tool_progressisoff, so the Desktop inline clarify UI has a pending tool row to mount on.Test Plan
python -m pytest tests/test_tui_gateway_server.py::test_clarify_lifecycle_emits_when_tool_progress_off tests/test_tui_gateway_server.py::test_non_blocking_tool_lifecycle_stays_hidden_when_tool_progress_off -qpython -m py_compile tui_gateway/server.py tests/test_tui_gateway_server.pygit diff --checkNotes
scripts/run_tests.sh tests/test_tui_gateway_server.py; the new tests passed, but the file run hit an unrelated local environment failure intest_browser_manage_connect_default_local_reports_launch_hintwhere the expected “No supported Chromium-family browser executable was found” launch-hint line was not present.