fix(installer): kill venv processes before removing venv dir (#47557) - #47610
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(installer): kill venv processes before removing venv dir (#47557)#47610kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
Collaborator
|
Duplicate of #46726 — both PRs fix #47557 with the same mechanism: stop processes running out of the venv ( |
4 tasks
Contributor
Author
|
Stale — oldest open PR, no merge activity for weeks. |
This was referenced Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #47557. On Windows, scripts/install.ps1 recreates the venv by removing the old directory, but python.exe and pythonw.exe processes holding .pyd native extensions as loaded DLLs prevent deletion. The fix kills hermes.exe, python.exe, and pythonw.exe processes running from the venv before removal, with a retry if the first Remove-Item fails.