fix(feishu): add open group active context - #47581
Conversation
|
Thanks for the focused Feishu context work. This needs substantial rework for current main. Problems
Suggested changes
Automated hermes-sweeper review. |
|
Hi @YuanHanzhong — wanted to flag this PR as a real-world need: I'm running Hermes-Feishu in a 3-person work group where users frequently ask the bot to "summarize what we just discussed", and the bot currently has zero visibility into messages between @-mentions. Issue #25728 captures this same ask. I read through the diff and the sweeper's three blockers carefully. They're all reasonable and I think they can be fixed in one pass without changing the design:
Happy to send a port-PR against main that lands these three fixes plus the existing tests moved to the new layout, if useful. But no urgency — if you're mid-revision, please drive it. Just want to avoid stomping. |
Summary
group_rules[chat_id].policy=opento authorize human group messages without globally allowing every senderchannel_contextfor follow-up messageslatest_by_chat.latest_purposeandupdated_atstate when a recent-context state path is configuredRelated issues / prior art
Validation
/Users/xiashui/.hermes/hermes-agent/.venv/bin/python -m pytest tests/gateway/test_feishu_active_context.py tests/gateway/test_unauthorized_dm_behavior.py tests/gateway/test_feishu_bot_admission.py tests/gateway/test_feishu_bot_auth_bypass.py tests/gateway/test_feishu.py tests/gateway/test_text_batching.py::TestFeishuAdaptiveDelay -q=> 269 passed / 45 skipped/Users/xiashui/.hermes/hermes-agent/.venv/bin/python -m compileall -q gateway/platforms/feishu.py tests/gateway/test_feishu_active_context.py gateway/authz_mixin.py tests/gateway/test_unauthorized_dm_behavior.py=> PASSNot included