fix: expose configured external memory provider tools across dispatch paths - #4749
Closed
davetist wants to merge 1 commit into
Closed
fix: expose configured external memory provider tools across dispatch paths#4749davetist wants to merge 1 commit into
davetist wants to merge 1 commit into
Conversation
Contributor
|
Already fixed on main via PR #4803 (merged). The memory provider dispatch block in _execute_tool_calls_sequential is identical to this fix. Thanks for catching the same issue! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
External memory providers are initialized inside run_agent.py, so their tools work when requests flow through the normal AIAgent path. But some Hermes execution paths call model_tools.handle_function_call() directly. In those paths, configured memory-provider tools can still show up as unknown or unavailable even though the provider is configured and working elsewhere.
Approach
Testing
Full suite status in my local environment: the repo is not fully green on main right now. The full run completed with unrelated existing failures outside this change area, including tools config, website policy, file read guards, tavily/web, vision URL validation, and approval E2E. The targeted regression file for this change passes cleanly.
Why draft
Opening as draft first because I want maintainers to decide whether they prefer this direct-dispatch bridge in model_tools.py or a different central place for external memory-provider exposure.