fix(gateway): preserve interrupt session routing - #47458
Closed
markoub wants to merge 1 commit into
Closed
Conversation
Contributor
|
Closing along with #47445 — after tracing the issue's mechanism against current Appreciate the clean implementation and tests — the premise just doesn't hold on current main. If you can reproduce wrong-thread delivery on a current build, please comment on #47445 with a gateway.log excerpt. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve the cached source for a gateway session when a pending or interrupting event is replayed under the original session key, so streaming and status sends can keep Mattermost/Telegram thread routing instead of falling back to the flat channel.
Changes
SessionSourcefor an active session instead of replacing it during replayed follow-ups_thread_metadata_for_session_source()so current-source thread metadata still wins, while missing metadata falls back to the cached session sourceFixes #47445.
Validation
uv sync --frozen --extra dev --extra messaginguv run scripts/run_tests.sh tests/gateway/test_session_source_cache.py tests/gateway/test_mattermost.py tests/gateway/test_stream_consumer_thread_routing.py -- --tb=long(71 passed)uv run ruff check gateway/run.py tests/gateway/test_session_source_cache.pyuv run ty check tests/gateway/test_session_source_cache.pygit diff --checkgit diff --check origin/main...HEAD