Conversation
Contributor
|
Duplicate of #9833 — both extend the V4A patch path-extraction in |
Author
|
haha , i let hermes deal with the pr and didnt checked for known issues my bad |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Discovery / root cause
I found this by auditing file-tool path safety directly rather than working from an existing issue. The V4A parser accepts \ operations, but \ only extracted paths from \ headers before running the path guard pipeline. A \ header could therefore skip the preflight traversal/cross-profile/sensitive-path checks that other V4A operations receive.
Duplicate check: searched upstream issues for V4A/Move File/cross-profile patch variants and did not find an existing tracked issue for this specific bug.
Behavior before
A patch like this reached \ instead of being rejected by the path guard:
\\
The parser also accepts the no-space form , while the old guard regex required whitespace after .
Behavior after
Test plan
6 passed in 0.21s