fix(agent): harden tool sequencing and live guards - #47212
Closed
projetsjsl wants to merge 1 commit into
Closed
Conversation
Co-Authored-By: Codex <codex@openai.com>
Collaborator
|
Triage note: omnibus PR bundling three distinct fixes — (1) Responses-style tool_call_id normalization in the chat-completions transport, (2) HERMES_DISABLE_CLAUDE_CODE_KEYCHAIN guard for Anthropic Keychain reads, (3) coding_context marker-root walk fix. Consider splitting for focused review. Related: #43299 (live-system guard hardening — same area, different mechanism: argv[0]-only executable treatment vs. shell/sudo wrapper forms; touches test_live_system_guard.py while this PR touches the self-test). Not a duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
env -i PATH="$PATH" HOME="$HOME" TMPDIR="/tmp/hermes-tests" TZ=UTC LANG=C.UTF-8 LC_ALL=C.UTF-8 PYTHONHASHSEED=0 PYTHONDONTWRITEBYTECODE=1 venv/bin/python scripts/run_tests_parallel.py tests/agent/test_openai_tool_sequence_sanitizer.py tests/agent/transports/test_chat_completions.py tests/agent/test_anthropic_keychain.py tests/test_live_system_guard_self_test.py -- -q— 136 passedenv -i PATH="$PATH" HOME="$HOME" TMPDIR="/tmp/hermes-tests" TZ=UTC LANG=C.UTF-8 LC_ALL=C.UTF-8 PYTHONHASHSEED=0 PYTHONDONTWRITEBYTECODE=1 venv/bin/python scripts/run_tests_parallel.py -- -q— 31,476 passed;tests/hermes_cli/test_doctor.pytimed out under parallel runner capenv -i PATH="$PATH" HOME="$HOME" TMPDIR="/tmp/hermes-tests" TZ=UTC LANG=C.UTF-8 LC_ALL=C.UTF-8 PYTHONHASHSEED=0 PYTHONDONTWRITEBYTECODE=1 venv/bin/python -m pytest tests/hermes_cli/test_doctor.py -q— 66 passedGenerated with Codex