fix(models): merge curated list with live /v1/models for zai provider - #47164
Closed
x7peeps wants to merge 1 commit into
Closed
fix(models): merge curated list with live /v1/models for zai provider#47164x7peeps wants to merge 1 commit into
x7peeps wants to merge 1 commit into
Conversation
The /model picker for zai (Z.AI / GLM) only shows models returned by the live /v1/models endpoint, silently dropping entries from the curated _PROVIDER_MODELS list. When the live endpoint omits newer models (e.g. glm-5.2), users can't see them in the picker even though they work when set directly via /model or config. Add zai to the merge path already used by kimi-coding/kimi-coding-cn: curated models come first, then live additions are appended. This ensures no curated model is ever hidden by an incomplete live response. Closes NousResearch#47162
NullStateGGH
approved these changes
Jun 16, 2026
Collaborator
|
Closing in favor of #46857. Same root cause as your fix (#46850 / #47162) — the generic provider path returned only the live Thanks for the diagnosis and the link to #47162. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When using the Z.AI (GLM) provider, the
/modelpicker shows only models returned by the live/v1/modelsendpoint, silently dropping entries from the curated_PROVIDER_MODELSlist. When the live endpoint omits newer models (e.g.glm-5.2), users can't see them in the picker even though they work when set directly via/modelor config.Root Cause
In
provider_model_ids()(hermes_cli/models.py:2379), the generic profile-based live fetch path merges curated + live results only forkimi-coding/kimi-coding-cn. Thezaiprovider falls through toreturn live, discarding the curated list entirely.Fix
Add
zaito the merge set so curated models come first, then live additions are appended — ensuring no curated model is ever hidden by an incomplete live response.Closes #47162