Skip to content

fix(slack): re-apply bang→slash rewrite after @mention strip #47115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
zenplace-system wants to merge 1 commit into from
Closed

fix(slack): re-apply bang→slash rewrite after @mention strip #47115

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions gateway/platforms/slack.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2525,6 +2525,27 @@ async def _handle_slack_message(self, event: dict) -> None:
if is_mentioned:
# Strip the bot mention from the text
text = text.replace(f"<@{bot_uid}>", "").strip()
# Re-apply the ``!cmd`` → ``/cmd`` rewrite after stripping the bot
# mention. When a user types ``@bot !model ...`` the original text
# starts with ``<@...>`` so the earlier bang-rewrite pass (which
# only fires when the text starts with ``!``) is skipped. After
# mention-stripping the leading ``!`` is visible, so we run the
# same logic again here to normalise it to a slash command.
if text.startswith("!"):

@teknium1 teknium1 Jul 14, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Current main migrated this adapter to plugins/platforms/slack/adapter.py in 5600105478ffde29d7566b45421b100eaa29c4ef, so this hunk will not reach the active Slack runtime. Port the normalization there and apply it to the mention-stripped raw text rather than post-block-augmentation text.

try:
from hermes_cli.commands import is_gateway_known_command

first_token = text[1:].split(maxsplit=1)[0]
cmd_name = first_token.split("@", 1)[0].lower()
if (
cmd_name
and "/" not in cmd_name
and is_gateway_known_command(cmd_name)
):
text = "/" + text[1:]
original_text = text # keep original_text in sync for MessageType detection
except Exception: # pragma: no cover - defensive
pass
# Register this thread so all future messages auto-trigger the bot.
# Skipped in strict mode: strict_mention=true bots must be
# re-mentioned every turn, so remembering the thread would
Expand Down