fix: unblock Codex fallback and stabilize skill update hashes - #46915
Open
nicogentico wants to merge 2 commits into
Open
fix: unblock Codex fallback and stabilize skill update hashes#46915nicogentico wants to merge 2 commits into
nicogentico wants to merge 2 commits into
Conversation
nicogentico
force-pushed
the
fix/codex-fallback-and-skill-hash
branch
from
June 15, 2026 23:04
64ef529 to
41634b3
Compare
Contributor
|
Thanks for the focused regression coverage. The skill-hash half addresses a current asymmetry: disk hashing sorts Problems
Suggested changes
Automated hermes-sweeper review. |
This was referenced Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
usage_limit_reachederrors decline credential-pool recovery so configured fallback providers can activate immediately.content_hashpath ordering, fixing falseupdate_availablereports for skills that contain bothreferences/styles.mdand files underreferences/styles/.Why
Two update-time issues surfaced in a real Hermes install:
usage_limit_reached) is not recoverable by rotating credentials inside the same pool. Treating it like a pool-recoverable rate limit can delay or block fallback to OpenRouter.bundle_content_hash()andcontent_hash()intended to be symmetric, but sorted paths differently when a file and directory share a prefix. This made an installed skill with identical contents still appear outdated.Test Plan
python -m pytest tests/agent/test_credential_pool_routing.py -q -o 'addopts='python -m pytest tests/tools/test_skills_hub.py::TestCheckForSkillUpdates tests/agent/test_credential_pool_routing.py -q -o 'addopts='hermes skills checknow reports0 update(s) availableafter force-installingbaoyu-article-illustrator.