Skip to content

feat(memory): configurable background memory and skill notifications - #4684

Closed
WolframRavenwolf wants to merge 2 commits into
NousResearch:mainfrom
WolframRavenwolf:feat/memory-notifications
Closed

feat(memory): configurable background memory and skill notifications#4684
WolframRavenwolf wants to merge 2 commits into
NousResearch:mainfrom
WolframRavenwolf:feat/memory-notifications

Conversation

@WolframRavenwolf

@WolframRavenwolf WolframRavenwolf commented Apr 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Summary

Rebuilds this PR on current upstream/main and expands the notification feature to cover both memory and skill-management changes produced by the background review pass.

Adds display.memory_notifications with three modes:

  • off - no chat notification for background review memory/skill changes
  • on - generic notifications, preserving the old low-detail behavior by default
  • verbose - compact previews showing what was added/replaced/removed or which skill content changed

In verbose mode, the background review callback can now show memory content previews and skill change previews such as:

Memory + important future fact...
Skill 'demo' patched: "old text" -> "new text"

Motivation

The previous notification was opaque: users could see that the agent changed memory, but not what was changed. That is unnerving for durable state mutations. This keeps the default generic behavior while letting users opt into a concise, transparent preview.

Changes

  • Adds agent.memory_notifications state and gateway config wiring from display.memory_notifications.
  • Makes background review action summarization filter only memory/skill tool calls instead of treating any successful tool result as a durable-state update.
  • Uses tool-call arguments plus tool result metadata to build useful previews.
  • Includes skill patch/create/edit change metadata in skill_manage results for verbose notifications.

Verification

  • python3 -m py_compile agent/agent_init.py agent/background_review.py gateway/run.py tools/skill_manager_tool.py
  • Custom smoke for summarize_background_review_actions(..., notification_mode='off'/'on'/'verbose'), including memory add, skill patch, and ignored non-notification tool result

Notes

This update force-pushes the existing PR branch from the current upstream base rather than opening a duplicate PR.

@WolframRavenwolf WolframRavenwolf mentioned this pull request Apr 3, 2026
Closed
5 tasks
@alt-glitch alt-glitch added type/feature New feature or request P3 Low — cosmetic, nice to have comp/gateway Gateway runner, session dispatch, delivery tool/memory Memory tool and memory providers labels May 1, 2026
This was referenced May 23, 2026
Open
Closed
@WolframRavenwolf
WolframRavenwolf force-pushed the feat/memory-notifications branch from ce90495 to a90f030 Compare June 8, 2026 00:08
@WolframRavenwolf WolframRavenwolf changed the title feat(memory): configurable background memory update notifications feat(memory): configurable background memory and skill notifications Jun 8, 2026
@WolframRavenwolf
WolframRavenwolf force-pushed the feat/memory-notifications branch 4 times, most recently from 0fe41ac to 6d3a1cb Compare June 15, 2026 22:40
@WolframRavenwolf
feat(memory): configurable background memory update notifications
5713325 
Background memory reviews now support three notification modes,
configured via display.memory_notifications in config.yaml:

  off     — no chat notification (still logged to stdout/HA log)
  on      — generic '💾 Memory updated' (default, unchanged behavior)
  verbose — content preview with action indicators:
            💾 Memory ➕ Hermes Repo liegt unter /config/amy/hermes-agent/...
            💾 Memory ✏️ Updated repo path from claude-code to hermes-agent...
            💾 Memory ➖ old entry about claude-code path...

Previews are truncated to 120 chars for adds/replaces, 60 for removes.
Each action gets its own line in verbose mode for readability.

Files: run_agent.py, gateway/run.py
@WolframRavenwolf
feat(display): verbose skill change notifications with content previews
50ac089 
When display.memory_notifications is set to 'verbose', skill_manage
notifications now show meaningful change details instead of just the
generic tool message.

Before (verbose mode):
  💾 📝 Patched SKILL.md in skill 'gogcli' (1 replacement).

After (verbose mode):
  💾 📝 Skill 'gogcli' patched: "old pitfall text..." → "new pitfall text..."

Changes:
- skill_manager_tool.py: _patch_skill() now includes old/new string
  previews (truncated to 200 chars) in the result via '_change' key.
  _create_skill() and _edit_skill() include skill description from
  frontmatter for verbose create/edit notifications.
- run_agent.py: Background review notification builder now reads the
  '_change' dict from skill tool results and formats descriptive
  notifications per action type (patch → old→new diff, create/edit →
  description preview). Falls back to generic message when _change
  data is unavailable (backwards compatible).

This is especially useful when subagents patch skills, since neither
the user nor the parent agent can see what the subagent changed.
@WolframRavenwolf
WolframRavenwolf force-pushed the feat/memory-notifications branch from 6d3a1cb to 50ac089 Compare June 16, 2026 00:38
@teknium1 teknium1 mentioned this pull request Jun 16, 2026
Merged
@teknium1

teknium1 commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Merged via #47226 — your commits were cherry-picked onto current main with your authorship preserved in git log (rebase-merge).

The salvage adds display.memory_notifications (off | on | verbose) to DEFAULT_CONFIG, documents it in the memory feature docs, and adds resolver tests for the off/on/verbose paths (memory + skill_manage). The verbose skill-change previews and content-preview behavior from your second commit are all in. Thanks!

@teknium1 teknium1 closed this Jun 16, 2026
liuhao1024 pushed a commit to liuhao1024/hermes-agent that referenced this pull request Jun 16, 2026
@teknium1
feat(display): document and test memory_notifications setting
98ae286 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
alanbratu pushed a commit to alanbratu/hermes-agent that referenced this pull request Jun 17, 2026
@teknium1 @alanbratu
feat(display): document and test memory_notifications setting
cd6d3c8 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
zmlgit pushed a commit to zmlgit/hermes-agent that referenced this pull request Jun 17, 2026
@teknium1 张满良
feat(display): document and test memory_notifications setting
44ccd65 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
al3xar pushed a commit to al3xar/hermes-agent that referenced this pull request Jun 17, 2026
@teknium1 al3xar
feat(display): document and test memory_notifications setting
4e74181 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
xyshanren pushed a commit to xyshanren/hermes-agent-cn that referenced this pull request Jun 17, 2026
@teknium1 @xyshanren
feat(display): document and test memory_notifications setting
a23f438 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths

(cherry picked from commit 98ae286)
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
@teknium1
feat(display): document and test memory_notifications setting
a886340 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
Methodician added a commit to Methodician/hermes-agent that referenced this pull request Jul 4, 2026
@Methodician
feat(display): document and test memory_notifications setting
225623f 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
@teknium1
feat(display): document and test memory_notifications setting
1cad5eb 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
@teknium1
feat(display): document and test memory_notifications setting
3a57099 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
@teknium1
feat(display): document and test memory_notifications setting
d9ad477 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
@teknium1
feat(display): document and test memory_notifications setting
93db861 
Follow-up to salvaged PR NousResearch#4684:
- Add display.memory_notifications to DEFAULT_CONFIG (off|on|verbose, default on)
- Document the setting in docs/user-guide/features/memory.md
- Add resolver tests for off/on/verbose memory + skill paths
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

comp/gateway Gateway runner, session dispatch, delivery P3 Low — cosmetic, nice to have tool/memory Memory tool and memory providers type/feature New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@WolframRavenwolf @teknium1 @alt-glitch