-
Notifications
You must be signed in to change notification settings - Fork 52.2k
[codex] Add Discord read tools #4677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
orangebread
wants to merge
2
commits into
NousResearch:main
Choose a base branch
from
orangebread:feat/discord-read-tools
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| # Discord Read Tools Plan | ||
|
|
||
| Date: 2026-04-02 | ||
|
|
||
| ## Scope | ||
|
|
||
| Add three read-only Discord tools: | ||
|
|
||
| - `discord_list_channels` | ||
| - `discord_read_history` | ||
| - `discord_search_messages` | ||
|
|
||
| ## Design Constraints | ||
|
|
||
| - Use Discord HTTP API v10 only. | ||
| - Keep the feature read-only. | ||
| - Enforce explicit allowlists: | ||
| - `DISCORD_READ_ALLOWED_GUILDS` | ||
| - `DISCORD_READ_ALLOWED_CHANNELS` | ||
| - `DISCORD_READ_INCLUDE_DMS` | ||
| - Auto-allow the current Discord session target so Hermes can inspect the conversation it is already in. | ||
| - Include thread discovery and thread-aware name resolution. | ||
| - Hard-cap history and search sizes. | ||
| - Return message permalinks when possible. | ||
|
|
||
| ## Implementation Notes | ||
|
|
||
| - Guild allowlists expose readable text channels plus active threads in those guilds. | ||
| - Channel allowlists expose specific channels/threads directly; allowed parent text channels also expose active child threads. | ||
| - DM discovery is limited to channels Hermes already knows from prior sessions. | ||
| - Search scans a bounded recent-message window instead of pretending to be a full-server index. | ||
|
|
||
| ## Verification Targets | ||
|
|
||
| - Tool registration and `get_tool_definitions()` exposure. | ||
| - Allowlist denial outside scope. | ||
| - Current-session access for guild and DM contexts. | ||
| - Thread discovery and deterministic qualified-name resolution. | ||
| - Config bridging from `config.yaml` into Discord read env vars. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are non-secret behavioral allowlist settings. Please retain
discord.read.*inconfig.yamlas the user-facing interface and remove these entries from.envsetup; AGENTS.md requires behavioral settings to be documented in config rather than.env.