feat(feishu): render markdown tables as native Feishu card table components - #46727
Open
BiuDoom wants to merge 1 commit into
Open
feat(feishu): render markdown tables as native Feishu card table components#46727BiuDoom wants to merge 1 commit into
BiuDoom wants to merge 1 commit into
Conversation
Feishu's post/md format does not render GFM markdown tables, so FeishuAdapter._build_outbound_payload previously downgraded any message containing a table to plain text, losing all formatting and showing raw pipe characters to the user. This builds a Feishu card JSON 2.0 message with native table components when outbound content contains a markdown table, while non-table prose is preserved as markdown elements. Table cells use data_type markdown so inline formatting renders; row_height auto + row_max_height prevent truncation. Respects Feishu limits (<=5 tables/card, <=50 columns) and falls back to plain text on any breach, parse failure, or exception, so a message is never dropped. Existing post/text/approval-card paths are unchanged. Adds tests/gateway/test_feishu_table_card.py (17 tests).
BiuDoom
force-pushed
the
feat/feishu-markdown-table-card
branch
from
June 15, 2026 15:55
870c028 to
c1323e5
Compare
alt-glitch
added
type/feature
Collaborator
This was referenced Jun 24, 2026
teknium1
reviewed
Jul 14, 2026
teknium1
left a comment
teknium1
left a comment
Contributor
There was a problem hiding this comment.
Thanks for the focused table-rendering implementation. The underlying issue remains on current main: plugins/platforms/feishu/adapter.py:4524-4534 still downgrades detected tables to plain text.
Problems
- The branch at
gateway/platforms/feishu.py:4582returnsinteractive, but the current send and edit fallback paths only recover rejectedpostpayloads (plugins/platforms/feishu/adapter.py:1913-1936and:1963-1971). A rejected card would therefore fail instead of taking the claimed text fallback. tests/gateway/test_feishu_table_card.py:209-228duplicates the routing logic rather than invoking_build_outbound_payload, so it cannot catch drift in the production method.- The target adapter was relocated by
5600105478ffde29d7566b45421b100eaa29c4eftoplugins/platforms/feishu/adapter.py; this needs a port rather than applying the old-file diff directly.
Suggested changes
- Port the implementation to the bundled adapter and test rejected interactive-card send/edit responses falling back to text.
- Exercise the real adapter payload method in the routing tests.
Automated hermes-sweeper review.
| try: | ||
| card_json = _build_table_card(content) | ||
| if card_json is not None: | ||
| return "interactive", card_json |
Contributor
There was a problem hiding this comment.
This changes the outbound type to interactive, but the send and edit fallback paths only recover rejected post payloads. Add an interactive-card rejection fallback there as well, with a regression test, so an API-invalid card does not turn into a failed delivery.
| """ | ||
|
|
||
| def _call(self, content): | ||
| # The method is an instance method; replicate its logic via the helpers. |
Contributor
There was a problem hiding this comment.
This copies _build_outbound_payload instead of exercising it. Instantiate the adapter minimally or use the existing fixture and call the real method, otherwise a later production change can silently diverge from this test.
teknium1
added
sweeper:risk-message-delivery
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Feishu's
post/mdmessage format does not render GFM markdown tables (per Feishu's docs themdtag supports only a subset of markdown, and tables are not included).FeishuAdapter._build_outbound_payloadcurrently detects any markdown table and downgrades the entire message to plaintext, losing all formatting (bold, headings, lists) and showing raw| --- |pipes to the user.Change
When outbound content contains a markdown table, build a Feishu card JSON 2.0 message with native
tablecomponents, while non-table prose is preserved asmarkdownelements._split_content_into_blocks(orders prose / table / fenced-code blocks; code fences are never parsed as tables),_parse_gfm_table(GFM -> columns/rows),_build_table_card(assembles the card).data_type: "markdown"so inline formatting (e.g. bold) renders;row_height: "auto"+row_max_heightso long cells wrap instead of being truncated.post/text/ approval-card paths are unchanged.Tests
tests/gateway/test_feishu_table_card.py(17 tests): block splitting, GFM parsing, card structure, order preservation, fenced-pseudo-table exclusion, >5-table fallback, and_build_outbound_payloadrouting. Existingtest_feishu.py(205) andtest_feishu_approval_buttons.py(38) still pass.