Skip to content

fix: clear npm audit vulnerabilities - #46725

Closed
stigrunar wants to merge 1 commit into
NousResearch:mainfrom
stigrunar:fix/npm-audit-workspaces
Closed

fix: clear npm audit vulnerabilities#46725
stigrunar wants to merge 1 commit into
NousResearch:mainfrom
stigrunar:fix/npm-audit-workspaces

Conversation

@stigrunar

Copy link
Copy Markdown

Summary

  • bump Vite consumers in web and bootstrap installer to patched Vite 8.0.16
  • bump ui-tui/@hermes/ink esbuild to 0.28.1 and refresh the lockfile so transitive esbuild resolves to 0.28.1
  • bump desktop wait-on so Joi resolves to 18.2.1

Verification

  • npm audit --workspace web --audit-level=moderate
  • npm audit --workspace ui-tui --audit-level=moderate
  • npm audit --audit-level=moderate
  • npm run build --workspace web
  • npm run build --workspace apps/bootstrap-installer
  • npm run build --workspace ui-tui
  • npm run build --prefix ui-tui/packages/hermes-ink
  • npm run typecheck --workspace ui-tui
  • npm run typecheck --workspace apps/desktop
  • npm run typecheck --workspace apps/bootstrap-installer

Notes

  • npm test --workspace ui-tui currently fails in unrelated TUI layout tests: virtualHeights expected 3/received 4 and cursorDriftRegression timeout. The initial run also needed @hermes/ink dist/entry-exports.js to be built first.

@stigrunar
stigrunar requested a review from a team June 15, 2026 15:46
@alt-glitch alt-glitch added type/refactor Code restructuring, no behavior change P3 Low — cosmetic, nice to have dependencies Pull requests that update a dependency file javascript duplicate This issue or pull request already exists labels Jun 15, 2026
@alt-glitch

Copy link
Copy Markdown
Collaborator

Duplicate of #46543 — same npm audit clearing (Vite 8 / esbuild 0.28.1 / Joi bumps across web, ui-tui, hermes-ink, bootstrap-installer). #46543 is the earlier open twin; a maintainer salvage (#46652) clearing the same esbuild/Vite audit loop was also merged to main.

@teknium1

Copy link
Copy Markdown
Contributor

Thanks for the dependency-audit cleanup. This is now superseded by the remediation already on main; automated hermes-sweeper review recommends closing this duplicate.

  • 92a456f711ebbc7dba083094f7fc91f1dfd54904 (fix(cli,deps): clear esbuild audit loop) is on current main and upgraded the same web, TUI, and bootstrap-installer Vite/esbuild surfaces.
  • Current package-lock.json resolves esbuild to 0.28.1 (package-lock.json:10313), vite to 8.1.0 (package-lock.json:18849), wait-on to 9.0.10 (package-lock.json:19035), and joi to 18.2.3 (package-lock.json:12959).
  • This matches the maintainer's duplicate note linking the merged salvage in fix(cli,deps): clear esbuild audit loop #46652 (merge commit 29c6985590043fc672a6c9a7cdb9a8695388d1ac).

@teknium1 teknium1 closed this Jul 14, 2026
@teknium1 teknium1 added the sweeper:implemented-on-main Sweeper: behavior already present on current main label Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file duplicate This issue or pull request already exists P3 Low — cosmetic, nice to have sweeper:implemented-on-main Sweeper: behavior already present on current main type/refactor Code restructuring, no behavior change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants