fix(models): merge Z.AI curated models with live API results - #46623
fix(models): merge Z.AI curated models with live API results#46623Icather wants to merge 1 commit into
Conversation
Z.AI free-tier API returns only 2 models, so the curated list (_PROVIDER_MODELS['zai']) was invisible in the Dashboard picker. Add 'zai' to the set of providers that merge curated entries with live API results, matching the existing Kimi merge pattern.
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates model ID merging behavior so the zai provider is treated like the existing special-cased providers when combining curated and live model lists.
Changes:
- Adds
zaito the provider set that uses curated models as a base when merging live model IDs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| live = _p.fetch_models(api_key=api_key) | ||
| if live: | ||
| if normalized in {"kimi-coding", "kimi-coding-cn"}: | ||
| if normalized in {"kimi-coding", "kimi-coding-cn", "zai"}: |
|
Thanks for the PR. I’m going to close this one rather than merge it as-is. The Z.AI surfaces are split: If we fix this, it should be endpoint-aware: include Appreciate the report and the small targeted patch. |
Problem
Z.AI free-tier API returns only 2 models for some accounts, so the curated model list (
_PROVIDER_MODELS["zai"]) was invisible in the Dashboard picker. Only the API-returned models appeared, even though the curated list contains 18 models covering text, vision, and thinking tiers.Fix
Add
"zai"to the set of providers that merge curated entries with live API results inprovider_model_ids(). This matches the existing Kimi merge pattern:Curated models appear first (in priority order), then any additional models from the API.
Change
hermes_cli/models.py— 1 line, added"zai"to the merge set.