fix(dashboard): scope plugin routes to selected profile - #46426
Closed
iosub wants to merge 1 commit into
Closed
Conversation
Author
|
fix #46408 |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the dashboard plugin-related APIs to respect the selected management profile, aligning them with existing profile-scoped endpoints.
Changes:
- Added dashboard plugin API prefixes to the frontend’s profile-scoped routing logic.
- Scoped multiple
/api/dashboard/*endpoints on the web server to an optionalprofilequery parameter and keyed the plugin cache by active profile home. - Extended skills discovery to allow overriding the skills directory path and added tests for profile scoping behavior.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| web/src/lib/api.ts | Treats dashboard plugin endpoints as profile-scoped so the frontend sends requests to the selected profile. |
| tools/skills_tool.py | Adds an optional skills_dir override to skill discovery, supporting profile-specific scanning. |
| hermes_cli/web_server.py | Adds profile scoping to dashboard plugin endpoints and prevents cross-profile cache reuse. |
| tests/hermes_cli/test_web_server_profile_unification.py | Adds regression tests ensuring dashboard plugin endpoints and hub respect selected profile scoping. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+599
to
+609
| def _find_all_skills(*, skip_disabled: bool = False, skills_dir: Optional[Path] = None) -> List[Dict[str, Any]]: | ||
| """Recursively find all skills in ~/.hermes/skills/ and external dirs. | ||
|
|
||
| Args: | ||
| skip_disabled: If True, return ALL skills regardless of disabled | ||
| state (used by ``hermes skills`` config UI). Default False | ||
| filters out disabled skills. | ||
| skills_dir: Optional override for the skills directory. When provided, | ||
| scans this directory instead of the module-level SKILLS_DIR. Used | ||
| by the web server to serve skills for a specific profile via | ||
| ?profile= query parameter. |
iosub
force-pushed
the
fix/dashboard-plugins-profile-scope-main
branch
from
June 15, 2026 02:51
5fb6a13 to
bf1b6e9
Compare
Author
|
close with #46432 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix dashboard plugin discovery and management to respect the selected profile instead of falling back to the default one.
Changes
Verification