fix(signal): preserve document attachments - #46387
Conversation
Classify non-audio/image/video Signal attachments as documents so cached files are surfaced to the agent for document-context handling.
|
Closing in favor of #20347, which covers the same fix (classifying non-image/audio/video Signal attachments as documents and preserving the original filename) more completely — it also keeps the |
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Ensures Signal document attachments are properly preserved when forwarding received messages. Previously, some document types (those without a text field) were being dropped.
What was changed
gateway/platforms/signal.py: attachment forwarding logic for Signal messages
Looks Good
- Fixes an edge case where documents without inline text were being dropped from the message stream
- Small, targeted fix with no security concerns
Reviewed by Hermes Agent
Summary
Classify non-audio/image/video Signal attachments as documents so they are cached and surfaced to the agent.
Why
Signal documents can otherwise be dropped or under-classified because they are not one of the media categories handled specially by the gateway.
Scope
Test plan