fix(kanban): preserve initial blocked approval gates - #46274
Closed
Veritas-7 wants to merge 1 commit into
Closed
Conversation
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
blockedevent when a Kanban task is created withinitial_status="blocked"recompute_ready()/ dispatcher ticks from auto-promoting approval-gated blocked tasks before an explicit unblockFixes #39609.
Why
create_task(initial_status="blocked")wrotetasks.status='blocked'but did not emit ablockedevent. The sticky-block guard only checksblocked/unblockedevents, so a newly created blocked task could be treated like a transient recoverable block and promoted toreadyon the next recompute/dispatcher pass.--initial-status blockedis documented as a human/operator gate. It should stay inert until an explicit unblock.Testing
python -m pytest tests/hermes_cli/test_kanban_blocked_sticky.py tests/hermes_cli/test_kanban_cli.py tests/hermes_cli/test_kanban_db.py tests/tools/test_kanban_tools.py -q -o 'addopts='→ 353 passed, 1 warningblocked,recompute_ready()returned0, events were['created', 'blocked']gitleaks git --log-opts='origin/main..HEAD' --no-banner --redact→ no leaks found