fix(skills): filter platform-disabled skills from prompt (#46201) - #46220
Closed
Tranquil-Flow wants to merge 1 commit into
Closed
fix(skills): filter platform-disabled skills from prompt (#46201)#46220Tranquil-Flow wants to merge 1 commit into
Tranquil-Flow wants to merge 1 commit into
Conversation
Contributor
|
Reviewed the diff — LGTM. Clean fix with good test coverage. Details:
Note: #46203 (iborazzi) applies the same core fix but without the dedicated test coverage and with an unrelated |
Collaborator
Tranquil-Flow
force-pushed
the
fix/46201-disabled-skills-prompt
branch
from
June 16, 2026 16:00
3116a3c to
70f9ff0
Compare
Contributor
|
Thanks for the focused fix. This is an automated hermes-sweeper review; the reported behavior is already implemented on current
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #46201.
Disabled skills were still leaking into
<available_skills>for active platforms because prompt construction did not pass the resolved platform intoget_disabled_skill_names(). A second related bug meant platform-specific disables replaced the globalskills.disabledset instead of merging with it.This PR:
build_skills_system_prompt()disabled-skill filteringget_disabled_skill_names()Verification
Ran focused regression suite with the shared Hermes Python 3.11 venv:
/Users/evinova-self/.hermes/hermes-agent/venv/bin/python3 -m pytest \ tests/hermes_cli/test_skills_config.py \ tests/agent/test_prompt_builder.py \ -v -o "addopts=" --tb=shortResult:
164 passed, 1 skipped in 0.29s.Competitor analysis
An existing PR, #46203, addresses the same issue and has green CI, but it includes unrelated desktop/shared TypeScript config changes, line-ending churn in
tests/hermes_cli/test_skills_config.py, and weakens an existing prompt-builder test by removing an assertion. This PR keeps the fix focused to the Python prompt/skills paths and targeted tests only.Auto-published by Moonsong via Path B automated pipeline.