feat(feishu): add render_mode for interactive card rendering - #46191
Open
kindle4send wants to merge 1 commit into
Open
feat(feishu): add render_mode for interactive card rendering#46191kindle4send wants to merge 1 commit into
kindle4send wants to merge 1 commit into
Conversation
Feishu post-type md elements cannot render markdown tables — sending
table content as post causes blank messages. Interactive cards
(schema 2.0) support full markdown including tables and code blocks.
This commit adds a render_mode setting that controls how outbound text
messages are rendered:
- "auto" (default): use interactive card when content contains code
blocks or markdown tables; plain text / post otherwise.
- "card": always use interactive card.
- "raw": always use text/post (legacy behaviour, no cards).
Changes:
- Add render_mode field to FeishuAdapterSettings with config/env loading.
- Add _should_use_card() to detect code blocks and tables.
- Add _build_card_payload() for schema 2.0 interactive card format.
- Modify _build_outbound_payload() to route through card when appropriate.
- Add interactive card fallback in send() (card → post → text).
- Modify edit_message() to use PATCH API for card messages.
- Bridge render_mode from config.yaml to adapter extra in config.py.
- Add test_feishu_render_mode.py (23 tests).
- Update existing post-row-splitting test to use render_mode=raw.
Config example:
feishu:
render_mode: auto # auto | card | raw
Or via env: FEISHU_RENDER_MODE=card
Collaborator
|
Duplicate of #39045 ( |
Contributor
|
Thanks for addressing Feishu table and code-block rendering. The underlying current-main limitation is real: Problems
Suggested changes
Automated hermes-sweeper review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feishu post-type md elements cannot render markdown tables — sending table content as post causes blank messages. Interactive cards (schema 2.0) support full markdown including tables and code blocks.
This commit adds a render_mode setting that controls how outbound text messages are rendered:
Changes:
Config example:
feishu:
render_mode: auto # auto | card | raw
Or via env: FEISHU_RENDER_MODE=card
What does this PR do?
Related Issue
Fixes #
Type of Change
Changes Made
How to Test
Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings) — or N/Acli-config.yaml.exampleif I added/changed config keys — or N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — or N/AFor New Skills
hermes --toolsets skills -q "Use the X skill to do Y"Screenshots / Logs