fix: restore cron approval env after job runs - #46167
Closed
renanpsantos wants to merge 1 commit into
Closed
Conversation
Collaborator
Contributor
|
Verification: reviewed diff + tests — no issues found. Checked:
This is a clean fix for a real env-var-leak bug that would cause all sessions in a shared scheduler process to inherit headless cron approval behavior. |
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HERMES_CRON_SESSIONvalue before cron jobs set it_run_job_impl()cleanupRoot cause
HERMES_CRON_SESSIONwas being set process-wide for cron execution and left behind afterward. When the same gateway process later handled a normal chat session, approval logic could still see the cron flag and apply the headless cron policy incorrectly.Test Plan
venv/bin/python -m pytest tests/tools/test_cron_approval_mode.py tests/tools/test_execute_code_approval_cluster.py -qexecute_codeworks again outside cron after restarting the gateway