feat(secrets): proxy credential passthrough via config (#5) - #4592
Closed
dsr-restyn wants to merge 0 commit into
Closed
feat(secrets): proxy credential passthrough via config (#5)#4592dsr-restyn wants to merge 0 commit into
dsr-restyn wants to merge 0 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a config option for proxy-brokered credential placeholders (#4429). Sandboxed runtimes like NVIDIA OpenShell use credential brokering where env vars contain placeholders and a network proxy rewrites HTTP headers with real tokens on egress. Hermes strips these as if they were real secrets, breaking tools that depend on the placeholder being present.
Config
Listed vars bypass the provider-secret blocklist via the existing
env_passthroughmechanism. Output redaction still applies. Registration is config-driven (not agent-controllable) and runs once, guarded by a module-level flag set after the try block completes.Changes
hermes_cli/config.pyproxy_credentialsconfig keytools/environments/local.py_sanitize_subprocess_envand_make_run_env31 additions, 0 deletions. No existing code modified.
Related Issues
Addresses #4429
Part of #410 (Secure Secrets Management umbrella)
Open to suggestions!