fix(checkpoints): remove stale shadow index locks - #45871
Closed
Veritas-7 wants to merge 1 commit into
Closed
Conversation
Veritas-7
force-pushed
the
veritas/public-checkpoint-stale-index-lock-4bdde139
branch
2 times, most recently
from
June 14, 2026 00:18
e232e6e to
2d3ec5b
Compare
Contributor
Author
|
Closing this for now after the local two-reviewer gate found a remaining race window in stale index-lock cleanup. I will rework this into a safer follow-up before reopening/updating a replacement PR. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.lockfiles before running git commands against per-project shadow indexes.Why
A stale index lock can leave Hermes checkpoints stuck even though no writer is active. Cleaning only old and unchanged lock files makes checkpoint recovery self-healing without weakening active-lock safety.
Tests
python -m pytest tests/tools/test_checkpoint_manager.py -q -o 'addopts='gitleaks git --log-opts='origin/main..HEAD' --no-banner --redactgit diff --check origin/main..HEADSafety review