fix(email): subject-based thread_id isolation + suppress tool-progress spam by ygd58 · Pull Request #45600 · NousResearch/hermes-agent

ygd58 · 2026-06-13T12:36:19Z

Addresses maintainer review of #27811:

thread_id from subject slug — chat_id stays real sender address
format_tool_event() returns None — no inbox spam per tool call
_thread_context keyed by sender_addr consistently

plugins/google_meet/meet_bot.py spawns a paplay/ffmpeg subprocess stored as rt['pcm_pump'] but never calls terminate()/wait() on normal bot exit — leaving a zombie process (issue NousResearch#38032). Fix: add pcm_pump cleanup to the teardown block alongside the existing speaker thread and bridge teardown. Fixes NousResearch#38032

docker exec commands run as root inside the container, leaving jobs.json root-owned after any scheduler write or exec invocation. Unlike profiles/, the cron/ directory was not in the unconditional chown block — only in the conditional one gated by needs_chown. On container restart, root-owned jobs.json persists and breaks cross-profile cron execution (EACCES for the unprivileged hermes runtime in multi-profile setups). Same pattern as profiles/ fix. Fix: add cron/ to the unconditional chown block alongside profiles/. Fixes NousResearch#41966

…on test docker exec commands run as root inside the container, leaving jobs.json root-owned after any scheduler write or exec invocation. Unlike profiles/, the cron/ directory was not in the unconditional chown block — only the conditional one gated by needs_chown. On container restart, root-owned jobs.json persists and breaks cross-profile cron execution (EACCES for the unprivileged hermes runtime). Same pattern as profiles/ fix. Fix: add cron/ to the unconditional chown block alongside profiles/. Test: regression test that locks in both profiles/ and cron/ unconditional chowns and verifies cron/ chown is at the correct (unconditional) indent level. Fixes NousResearch#41966

…s spam Addresses three issues from maintainer review of NousResearch#27811: 1. thread_id from subject slug: chat_id stays as the real sender address (for SMTP delivery); thread_id carries a normalized subject slug so gateway.session gives per-thread session isolation (agent:main:email:dm:<sender>:<subject_slug>) without breaking the SMTP To header. 2. format_tool_event() override: returns None to suppress tool-progress chrome for email. Email is plain-text/non-editable — emitting a separate email per tool call would spam the inbox. Final assistant response is the only message sent. 3. _thread_context stays keyed by sender_addr (chat_id) — consistent with the SMTP delivery address, no synthetic keys. Fixes NousResearch#27811

ygd58 · 2026-06-13T12:38:15Z

@teknium1 Clean rewrite addressing your review of #27811:

chat_id stays as real sender address — SMTP To header never broken
thread_id carries normalized subject slug for per-thread isolation
_thread_context keyed by sender_addr consistently
Progress suppression moved to format_tool_event() override returning None

Could you take a look? Thanks!

tonydwb

Code Review Summary

Verdict: Approved

Email platform now uses a subject-based thread_id for session isolation, and tool-progress events are suppressed (format_tool_event returns None) to prevent inbox spam. Additionally, the Docker stage2 hook now unconditionally chowns cron/ on every boot to fix EACCES errors from root-owned jobs.json. All three changes are well-scoped with appropriate tests. No issues found.

Reviewed by Hermes Agent

teknium1

Thanks for the corrected email direction. The underlying email issues remain on current main, but this branch needs a focused port before it can be salvaged.

Problems

gateway/platforms/email.py was removed by 560010547; the active adapter is plugins/platforms/email/adapter.py:872-878, which still has no thread_id or format_tool_event() override. The proposed code therefore has no active runtime target.
gateway/platforms/email.py:487 keys "Help" as help but a normal reply subject "Re: Help" as re-help, splitting the thread the PR intends to preserve.
The diff adds no email regression coverage; tests/gateway/test_email.py needs cases for reply-stable session keys and suppressed tool chrome.
The Docker and Meet portions are already implemented on main (docker/stage2-hook.sh:282-287, plugins/google_meet/meet_bot.py:702-708). Keep Docker's current chown_hermes_tree path, which includes later symlink hardening.

Suggested changes

Port the email-only change to plugins/platforms/email/adapter.py, canonicalize reply prefixes before deriving the thread key, and add the active-adapter tests.

This is an automated hermes-sweeper review.

teknium1 · 2026-07-14T13:36:31Z

+        # chat_id stays as the real sender address (used for SMTP delivery);
+        # thread_id carries the subject anchor so gateway.session gives us
+        # agent:main:<platform>:dm:<sender>:<subject_slug> isolation.
+        _subject_slug = re.sub(r"[^a-z0-9]+", "-", subject.lower()).strip("-")[:80]


This does not keep normal email replies in one session: Help becomes help, while Re: Help becomes re-help. Canonicalize repeated reply/forward prefixes before deriving the key, and cover that pair with a regression test.

teknium1 · 2026-07-14T13:36:31Z

        logger.info("[Email] New message from %s: %s", sender_addr, subject)
        await self.handle_message(event)

+    def format_tool_event(self, event: Any, *, mode: str = "all",


This adapter path was migrated to plugins/platforms/email/adapter.py by 560010547, so this override is not active on current main. Port the method to the plugin adapter together with the thread-key change.

ygd58 · 2026-07-17T14:40:20Z

Closing — the active adapter at plugins/platforms/email/adapter.py already implements subject-based thread_id isolation with reply prefix canonicalization (re.sub strips Re:/Fwd: prefixes before deriving _thread_slug). The format_tool_event override and Docker/Meet portions mentioned here are also already on main. No further work needed on this branch.

ygd58 added 4 commits June 8, 2026 10:48

alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/email Email (IMAP/SMTP) adapter P2 Medium — degraded but workaround exists labels Jun 13, 2026

tonydwb approved these changes Jun 13, 2026

View reviewed changes

teknium1 reviewed Jul 14, 2026

View reviewed changes

ygd58 closed this Jul 17, 2026

This was referenced Aug 7, 2026

feat(gateway): add session_keying=gmail_thread_id mode for email adapter #11422

Open

feat(email): opt-in session isolation by normalized subject (#26277) #81018

Closed

withzombies mentioned this pull request Aug 9, 2026

fix(email): reply to all original recipients instead of only the sender #82543

Open

13 of 19 tasks

Navigation Menu

fix(email): subject-based thread_id isolation + suppress tool-progress spam - #45600

fix(email): subject-based thread_id isolation + suppress tool-progress spam#45600
ygd58 wants to merge 4 commits into
NousResearch:mainfrom
ygd58:fix/email-subject-session-isolation-v2

ygd58 commented Jun 13, 2026

Uh oh!

ygd58 commented Jun 13, 2026

Uh oh!

tonydwb left a comment

Uh oh!

teknium1 left a comment

Uh oh!

teknium1 Jul 14, 2026

Uh oh!

teknium1 Jul 14, 2026

Uh oh!

ygd58 commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

ygd58 commented Jun 13, 2026

Uh oh!

ygd58 commented Jun 13, 2026

Uh oh!

tonydwb left a comment

Choose a reason for hiding this comment

Code Review Summary

Uh oh!

teknium1 left a comment

Choose a reason for hiding this comment

Problems

Suggested changes

Uh oh!

teknium1 Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

teknium1 Jul 14, 2026

Choose a reason for hiding this comment

Uh oh!

ygd58 commented Jul 17, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants