Skip to content

fix(model): show bare custom endpoints in gateway picker - #45597

Merged
teknium1 merged 1 commit into
mainfrom
hermes/hermes-efdbb028
Jun 13, 2026
Merged

fix(model): show bare custom endpoints in gateway picker#45597
teknium1 merged 1 commit into
mainfrom
hermes/hermes-efdbb028

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

Bare model.provider: custom gateway configs now show their active endpoint in /model and can switch models from the picker without requiring a named providers: row.

Changes

  • hermes_cli/model_switch.py: add a model-config fallback row for direct custom endpoints and route explicit bare custom switches through the current base URL/API key.
  • tests/hermes_cli/test_model_switch_custom_providers.py: cover picker listing and explicit switch behavior for model.provider: custom + model.base_url configs.

Validation

Check Result
Failing regression tests before fix 2 failed
scripts/run_tests.sh tests/hermes_cli/test_model_switch_custom_providers.py 25 passed
Manual picker/switch probe custom row surfaced; switch stayed on https://www.ccsub.net/v1

Infographic

Bare custom endpoints appear in model picker

@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: hermes/hermes-efdbb028 vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 10892 on HEAD, 10890 on base (🆕 +2)

🆕 New issues (2):

Rule Count
unresolved-attribute 2
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
run_agent.py:2891: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`

✅ Fixed issues (1):

Rule Count
invalid-assignment 1
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`

Unchanged: 5712 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
@teknium1
teknium1 force-pushed the hermes/hermes-efdbb028 branch from f20ff0c to b6025d1 Compare June 13, 2026 12:55
@teknium1
teknium1 merged commit 74c5158 into main Jun 13, 2026
28 checks passed
@teknium1
teknium1 deleted the hermes/hermes-efdbb028 branch June 13, 2026 13:05
AIalliAI pushed a commit to AIalliAI/Hermes that referenced this pull request Jun 14, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request Jun 18, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
xyshanren pushed a commit to xyshanren/hermes-agent-cn that referenced this pull request Jun 25, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
habarmc1223-sudo pushed a commit to habarmc1223-sudo/hermes-agent-fluxmem that referenced this pull request Jul 8, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
donbowman pushed a commit to donbowman/hermes-agent that referenced this pull request Jul 13, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
…h#45597)

Surface direct model.provider=custom endpoints in /model picker output and keep explicit bare custom switches on the current endpoint instead of requiring a named providers/custom_providers row.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant