fix(desktop): hand off Windows bootstrap recovery - #45594
Merged
Conversation
Contributor
🔎 Lint report:
|
AIalliAI
pushed a commit
to AIalliAI/Hermes
that referenced
this pull request
Jun 14, 2026
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
habarmc1223-sudo
pushed a commit
to habarmc1223-sudo/hermes-agent-fluxmem
that referenced
this pull request
Jul 8, 2026
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
donbowman
pushed a commit
to donbowman/hermes-agent
that referenced
this pull request
Jul 13, 2026
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows Desktop recovery now hands broken bootstrap installs back to Hermes Setup so the running app releases
app.asarbefore installer repair touches the checkout.Changes
bootstrap-needed, spawn stagedhermes-setup.exein detached recovery mode and quit instead of runninginstall.ps1from inside the app bundle that is still holdingapp.asar.resources/app.asarbefore update/repair proceeds, then force-kill Hermes stragglers if either stays locked.app.asarlock targets.Validation
node --check apps/desktop/electron/main.cjsnode --test --test-name-pattern "intentional or interactive desktop child processes stay documented" apps/desktop/electron/windows-child-process.test.cjsgit diff --check origin/main..HEADcargo test lock --manifest-path apps/bootstrap-installer/src-tauri/Cargo.tomldbus-1.pc/libdbus-1-dev, before tests compileRoot cause from the user logs: repair/bootstrap was trying to remove
apps/desktop/release/win-unpacked/resources/app.asarwhile the packaged Desktop process still had that asar loaded.Infographic