fix(cli): preserve resize renderer state - #45586
Merged
Merged
Conversation
Contributor
🔎 Lint report:
|
| Rule | Count |
|---|---|
unresolved-attribute |
2 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [unresolved-attribute] unresolved-attribute: Unresolved attribute `_credits_session_start_micros` on type `AIAgent`
run_agent.py:2891: [unresolved-attribute] unresolved-attribute: Object of type `Self@get_credits_spent_micros` has no attribute `_credits_session_start_micros`
✅ Fixed issues (3):
| Rule | Count |
|---|---|
unresolved-import |
2 |
invalid-assignment |
1 |
First entries
tests/run_agent/test_credits_notices_toggle.py:76: [invalid-assignment] invalid-assignment: Object of type `None` is not assignable to attribute `_credits_session_start_micros` of type `int`
tests/cli/test_cli_status_bar.py:163: [unresolved-import] unresolved-import: Cannot resolve imported module `prompt_toolkit.utils`
tests/cli/test_cli_status_bar.py:162: [unresolved-import] unresolved-import: Cannot resolve imported module `prompt_toolkit.application`
Unchanged: 5709 pre-existing issues carried over.
Diagnostics are surfaced as warnings — this check never fails the build.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Classic CLI resize recovery now preserves prompt_toolkit's live cursor cache before resize erases, preventing duplicated prompt/input artifacts while keeping CJK-aware input-height calculation shared and tested.
Changes
cli.py: run prompt_toolkit's original resize handler before any Hermes renderer reset/invalidate sorenderer.erase()can clear from the correct prompt origin.cli.py: extract_estimate_tui_input_height()so prompt width is counted only on logical line 0 and CJK/wide characters use terminal cell width.tests/cli: replace duplicated test-local input-height code with direct invariant tests for the shared helper and resize call order.Related reports / PRs
Validation
python3 -m py_compile cli.pyscripts/run_tests.sh tests/cli/test_cli_force_redraw.py tests/cli/test_cli_status_bar.py tests/cli/test_cli_terminal_response_sanitizer.pyInfographic