fix(tui): preserve custom provider identity on resume - #45581
Closed
teknium1 wants to merge 1 commit into
Closed
Conversation
Contributor
🔎 Lint report:
|
Contributor
Author
|
Closing as superseded by PR #45578, which merged the same custom-provider Desktop/TUI resume fix onto current main. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Desktop/TUI session resume now preserves named custom provider identity instead of persisting only the resolved
customprovider.Changes
runtime_provider: add a base_url →custom:<name>lookup acrossproviders:andcustom_providers:entries.tui_gateway: persist named custom provider identity in sessionmodel_configand heal legacy rows that only stored barecustomby using the savedbase_url.Validation
scripts/run_tests.sh tests/hermes_cli/test_custom_provider_identity.py tests/tui_gateway/test_custom_provider_session_persistence.py_runtime_model_config→_stored_session_runtime_overrides→_make_agentcustom:mimo-v2.5-pro; resolved entry API keyFixes #44022.
Salvages the focused fix from #44109; #44402 is already on main and #44061 is a broad rollup, not the merge vehicle for this bug.
Infographic