fix(tts): include feishu in want_opus platforms - #45555
Closed
Asanilo wants to merge 1 commit into
Closed
Conversation
Asanilo
force-pushed
the
fix/feishu-want-opus
branch
from
June 13, 2026 11:26
019fef3 to
1a1e207
Compare
Asanilo
force-pushed
the
fix/feishu-want-opus
branch
from
June 13, 2026 12:05
1a1e207 to
159b474
Compare
Asanilo
force-pushed
the
fix/feishu-want-opus
branch
from
June 13, 2026 12:18
159b474 to
f4b0bb3
Compare
tonydwb
approved these changes
Jun 13, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Simple one-liner fix that adds "feishu" to the want_opus platform set. Feishu requires Opus audio format for TTS output and the TTS tool was not including feishu in the platforms that request Opus encoding. Clean fix with no concerns.
Reviewed by Hermes Agent
This was referenced Jun 13, 2026
7 tasks
This was referenced Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Extends
want_opusplatform set to includefeishualongsidetelegram, so minimax TTS on Feishu converts mp3 → ogg and gets delivered as voice bubble instead of file attachment.Related Issue
Fixes #45557
Type of Change
Changes Made
tools/tts_tool.py: changedwant_opus = (platform == 'telegram')→want_opus = platform in {'telegram', 'feishu'}tests/tools/test_tts_opus_routing.py: addedtest_minimax_feishu_converts_to_opus_voiceHow to Test
PYTHONPATH=. venv/bin/python -m pytest tests/tools/test_tts_opus_routing.py -v— all 3 tests passChecklist
fix(tts):)PYTHONPATH=. venv/bin/python -m pytest tests/tools/test_tts_opus_routing.py -q— all pass