Skip to content

fix(tts): include feishu in want_opus platforms - #45555

Closed
Asanilo wants to merge 1 commit into
NousResearch:mainfrom
Asanilo:fix/feishu-want-opus
Closed

fix(tts): include feishu in want_opus platforms#45555
Asanilo wants to merge 1 commit into
NousResearch:mainfrom
Asanilo:fix/feishu-want-opus

Conversation

@Asanilo

@Asanilo Asanilo commented Jun 13, 2026

Copy link
Copy Markdown

What does this PR do?

Extends want_opus platform set to include feishu alongside telegram, so minimax TTS on Feishu converts mp3 → ogg and gets delivered as voice bubble instead of file attachment.

Related Issue

Fixes #45557

Type of Change

  • 🐛 Bug fix (non-breaking change that fixes an issue)

Changes Made

  • tools/tts_tool.py: changed want_opus = (platform == 'telegram')want_opus = platform in {'telegram', 'feishu'}
  • tests/tools/test_tts_opus_routing.py: added test_minimax_feishu_converts_to_opus_voice

How to Test

  1. Send a TTS message via Feishu DM with minimax TTS provider
  2. Confirm message arrives as voice bubble (not mp3 attachment)
  3. Run: PYTHONPATH=. venv/bin/python -m pytest tests/tools/test_tts_opus_routing.py -v — all 3 tests pass

Checklist

  • I've read the Contributing Guide
  • My commit messages follow Conventional Commits (fix(tts):)
  • I've searched for existing PRs to make sure this isn't a duplicate
  • My PR contains only changes related to this fix
  • I've run PYTHONPATH=. venv/bin/python -m pytest tests/tools/test_tts_opus_routing.py -q — all pass
  • I've added tests for my changes

@Asanilo
Asanilo force-pushed the fix/feishu-want-opus branch from 019fef3 to 1a1e207 Compare June 13, 2026 11:26
@alt-glitch alt-glitch added type/bug Something isn't working comp/gateway Gateway runner, session dispatch, delivery platform/feishu Feishu / Lark adapter tool/tts Text-to-speech and transcription P2 Medium — degraded but workaround exists labels Jun 13, 2026
@Asanilo
Asanilo force-pushed the fix/feishu-want-opus branch from 1a1e207 to 159b474 Compare June 13, 2026 12:05
@Asanilo
Asanilo force-pushed the fix/feishu-want-opus branch from 159b474 to f4b0bb3 Compare June 13, 2026 12:18

@tonydwb tonydwb left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review Summary

Verdict: Approved

Simple one-liner fix that adds "feishu" to the want_opus platform set. Feishu requires Opus audio format for TTS output and the TTS tool was not including feishu in the platforms that request Opus encoding. Clean fix with no concerns.


Reviewed by Hermes Agent

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp/gateway Gateway runner, session dispatch, delivery P2 Medium — degraded but workaround exists platform/feishu Feishu / Lark adapter tool/tts Text-to-speech and transcription type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

minimax TTS on Feishu sends mp3 as file attachment instead of voice bubble

3 participants