fix(cron): treat webui origin as local delivery + failure messages (#45360) - #45459
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(cron): treat webui origin as local delivery + failure messages (#45360)#45459kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
alt-glitch
added
type/bug
tonydwb
approved these changes
Jun 13, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Fix: treats WebUI-origin cron jobs as local delivery and includes proper failure message handling. Previously WebUI-originated cron jobs were incorrectly treated as remote, causing delivery mismatches.
Looks Good
- Well-scoped fix targeting the WebUI origin detection path
- Clear failure message for delivery errors
- No security concerns
Collaborator
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #45360. Two fixes for WebUI-created cron jobs: (1) When deliver=origin and origin.platform is webui/desktop/cli, treat it as local delivery instead of routing through gateway platform adapters, which would record 'unknown platform' errors since these platforms read sessions from the local DB. (2) When the cron agent fails before producing a response, append a concise assistant failure message to the session so WebUI/Desktop show a readable transcript instead of a prompt-only chat.