fix(desktop): make right-sidebar refresh button always visible instead of hover-reveal - #45450
Closed
XueQi-2957 wants to merge 2 commits into
Closed
XueQi-2957 wants to merge 2 commits into
XueQi-2957 wants to merge 2 commits into
Conversation
The refresh button in the file tree's section header used a hover-reveal pattern (HEADER_ACTION_LABEL_REVEAL): it was opacity-0 + pointer-events-none by default and only appeared when hovering the adjacent folder-name label (peer/project-label). This created a usability deadlock: as the user moved their mouse from the label toward the button, they left the label — the peer-hover CSS stopped applying — causing the button to disappear before the cursor could reach it. Fix: use the same always-visible HEADER_ACTION_CLASS as the other toolbar buttons (open-folder, collapse-all). Remove the now-unused HEADER_ACTION_LABEL_REVEAL constant.
tonydwb
approved these changes
Jun 13, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
UX improvement: the sidebar refresh button is now always visible instead of requiring hover on desktop. Small but meaningful usability fix for the right panel.
Looks Good
- Single CSS/styling change (hover-reveal → always-visible)
- No security concerns, no test changes needed
5 tasks
Collaborator
|
Thanks for the focused desktop usability report and patch. Automated hermes-sweeper review found that current
Closing as implemented on main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug Description
The refresh button in the file explorer's top bar (right-sidebar) was only visible when hovering over the folder-name label. As the user moved their mouse from the label toward the button, they left the label area — causing the button to disappear before they could click it, making the refresh button effectively unusable.
Root Cause
The refresh button used
HEADER_ACTION_LABEL_REVEALCSS classes:This made the button invisible (
opacity-0) and non-interactive (pointer-events-none) by default. It only became visible when the adjacent folder-name label (.peer/project-label) was hovered — but moving the cursor toward the button left the label, removing thepeer-hoverstate and hiding the button again.Fix
classNamefromHEADER_ACTION_LABEL_REVEALtoHEADER_ACTION_CLASS— the same always-visible class used by the open-folder and collapse-all buttons.HEADER_ACTION_LABEL_REVEALconstant and update the comment.How to Verify
Risk Assessment
Low — only a CSS class change on one button. The other two toolbar buttons (open-folder, collapse-all) already use
HEADER_ACTION_CLASSwith no issues. The worst case is the button remains visible when it shouldn't be, which is the desired behavior.