fix(agent): preserve Copilot provider for explicit base URL

[maxpetrusenkoagent]

Summary

• Preserve explicit first-class providers when an auxiliary task also supplies a base URL.
• Keep bare base_url behavior as custom, so direct OpenAI-compatible endpoints still work.
• Add regression coverage for Copilot provider identity, Copilot auth/header routing, and the direct OpenAI alias fallback.

Fixes #45276

Test Plan

• $HOME/.hermes/hermes-agent/venv/bin/python -m pytest tests/agent/test_auxiliary_provider_input.py tests/agent/test_vision_routing_31179.py::TestOpenAiAliasForAuxiliary tests/run_agent/test_copilot_native_vision_headers.py -q

[tonydwb]

Code Review Summary

Verdict: Approved

Clean, well-scoped fix/feature with comprehensive tests. No issues found.

• Logic is correct and focused
• Tests cover the new behavior
• No security concerns
• Good error handling

---

Reviewed by Hermes Agent

[maxpetrusenkoagent]

Review-fix sweep complete.

Summary:

• Fixed one autoreview blocker: explicit provider="auto" with base_url now resolves to custom, so the caller's explicit endpoint wins instead of falling through to auto-detection.
• Added regression coverage for the auto + base_url path alongside the existing Copilot/openai alias cases.
• Marked the PR ready for review after pushing the fix.

Verification:

• RED: python -m pytest tests/agent/test_auxiliary_provider_input.py::test_auto_provider_with_explicit_base_url_routes_as_custom -q failed before the fix with provider == "auto".
• GREEN: same test passed after the fix.
• scripts/run_tests.sh tests/agent/test_auxiliary_provider_input.py tests/agent/test_vision_routing_31179.py tests/run_agent/test_copilot_native_vision_headers.py -> 19 passed.
• python -m ruff check . -> passed, with pre-existing invalid # noqa warning on run_agent.py:93.
• python scripts/check-windows-footguns.py --all -> passed.
• python -m compileall -q agent/auxiliary_client.py tests/agent/test_auxiliary_provider_input.py -> passed.
• Focused autoreview on the updated diff -> no blockers.

Current external blocker:

• GitHub Actions for this fork PR are action_required with no jobs/logs yet. A maintainer needs to approve workflow execution before CI can produce pass/fail results.

Confidence: high on the code fix; CI is pending maintainer workflow approval.

[maxpetrusenkoagent]

Review-fix sweep found no actionable blockers.\n\nCurrent state:\n- PR head is up to date at 0d520a923 on hermes/oss-pr-2026-06-13-hermes-agent-45276.\n- Reviews/comments: no unresolved inline review comments; latest review is approved.\n- Checks: GitHub Actions check suites are action_required with no check runs/logs exposed yet, so there is nothing local to reproduce.\n\nBlocker is external: a maintainer needs to approve workflow execution for this fork PR before CI can report pass/fail.

[maxpetrusenkoagent]

Review-fix sweep complete

No actionable blockers found.

Current state:

• PR head: 0d520a923 on hermes/oss-pr-2026-06-13-hermes-agent-45276 (already pushed)
• mergeable: true (confirmed via API)
• Reviews: 1 APPROVED (tonydwb)
• Checks: none reported — fork PR needs maintainer to approve workflow execution

Local verification:

• pytest tests/agent/test_auxiliary_provider_input.py — 4/4 passed
• ruff check on touched files — clean
• ty check on agent/auxiliary_client.py — 0 new diagnostics on changed lines (143 pre-existing)
• Diff: 2 files, +19/-1 (auxiliary_client fix + regression test)

The fix: provider="auto" with explicit base_url now correctly returns "custom" instead of falling through to auto-detection. The second commit also restores the provider="copilot" case that was dropped in the first commit.

[maxpetrusenkoagent]

Review-fix sweep complete

No actionable blockers.

Fix applied: Removed 2 trailing whitespace characters in docstrings on lines 4214 and 4223 of . These were introduced by the PR and flagged by . No logic changes.

Current state:

• PR head: bd31492e2 — 3 commits ahead of main
• mergeable: MERGEABLE
• Reviews: 1 APPROVED (tonydwb), no unresolved inline comments
• Checks: fork PR CI still action_required — no check runs exposed yet; external blocker requires a maintainer to approve workflow execution

Local verification:

• ruff --select=W293 on agent/auxiliary_client.py → All checks passed
• pytest tests/agent/test_auxiliary_provider_input.py → 4/4 passed
• pytest tests/agent/test_vision_routing_31179.py tests/run_agent/test_copilot_native_vision_headers.py → 15/15 passed

Confidence: high. The PR is clean, approved, and mergeable. CI remains blocked on maintainer workflow approval for fork PRs.

[maxpetrusenkoagent]

Review-fix sweep found no actionable blockers.

Current state:

• PR head is up to date at bd31492e2 on hermes/oss-pr-2026-06-13-hermes-agent-45276.
• Local worktree, PR ref, and fork ref all point to the same SHA.
• Reviews/comments: latest review is approved; no unresolved inline review comments.
• Mergeability: mergeable=true, mergeable_state=blocked.
• Checks: GitHub Actions suites are all action_required with 0 check runs/logs exposed, so there is no failing job to reproduce or fix locally.

Blocker is external: a maintainer needs to approve workflow execution for this fork PR before CI can report pass/fail.

[teknium1]

Thanks for the focused Copilot regression coverage. This is an automated hermes-sweeper review: the requested behavior is already implemented on main through the broader merged salvage in #55605.

• Merge commit a8841e2a (fix(aux): preserve provider identity for resolved endpoints) implements this at agent/auxiliary_client.py:5930-5972: catalog-recognized first-class providers keep their identity with an explicit base_url, while auto, custom, unknown, and direct-OpenAI-alias routes retain the custom fallback.
• tests/agent/test_auxiliary_client.py:125-169 covers both boundaries, and tests/run_agent/test_moa_loop_mode.py:180-215 covers the provider-backed MoA path.
• fix(aux): preserve provider identity for resolved endpoints #55605's merged PR discussion explicitly identifies fix(agent): preserve Copilot provider for explicit base URL #45330 as the same provider-identity mechanism and landed the generalized implementation with preserved contributor authorship from the duplicate-fix cluster.