feat(desktop): expand the full command inline from the approval bar - #44864
Merged
teknium1 merged 2 commits intoJun 13, 2026
Merged
Conversation
The native desktop approval bar deliberately omits the command because the pending tool row "already shows it" — but that row only renders a single truncated line, and a pending row can't be expanded (it has no result yet). So the full command was only reachable by opening the "Always allow" dropdown, reading the modal, cancelling, then clicking Run — 4-5 clicks just to see what you're approving. Add a "Command" toggle to the approval bar that reveals the full `request.command` inline (reusing the dialog's pre styling), default collapsed. Approving a long command is now "expand, Run". Gated on a non-empty command so zero-command approvals are unaffected.
Asserts the full command is absent until the Command toggle is clicked, then rendered in full — guarding the long-command reveal path.
xxxigm
force-pushed
the
feat/desktop-inline-approval-command
branch
from
June 12, 2026 11:33
9e125af to
ed99792
Compare
alt-glitch
added
type/feature
tonydwb
approved these changes
Jun 12, 2026
tonydwb
left a comment
tonydwb
left a comment
There was a problem hiding this comment.
Good UX improvement. Adds a Command toggle button in the tool approval bar to reveal the full command inline instead of truncated. Avoids modal dance for simple command inspection. Test coverage added. No issues found.
This was referenced Jun 12, 2026
1 task
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the Ink/TUI fix that wrapped long approval commands — the native desktop approval bar (
apps/desktop/src/components/assistant-ui/tool-approval.tsx) was untouched and still hides the command.The bar deliberately omits the command (comment: "the row already shows the command, so the strip deliberately doesn't repeat it"), but:
view.title, andso the full command was only reachable by opening the "Always allow…" dropdown → reading the modal → cancelling → clicking Run. As a reporter put it, "4-5 clicks every time an approval shows."
This adds a "Command" toggle to the approval bar that reveals the full
request.commandinline (reusing the Always-allow dialog's<pre>styling), default-collapsed. Approving a long command becomes "expand, Run" (2 clicks). The toggle is gated on a non-empty command, so approvals without a command string are visually unchanged.command) across en/zh/zh-hant/ja + types.Test plan
npx vitest run --environment jsdom src/components/assistant-ui/tool-approval.test.tsx(6 passed)npm run typecheck(clean)eslinton touched files (no new warnings; the one warning is pre-existing on therespondcallback)Infographic