fix(cli): use correct dict key for codex auth file path in status output - #448
Merged
teknium1 merged 1 commit intoMar 6, 2026
Merged
Conversation
Contributor
|
Merged in ecb8148 🎉 Thanks @PercyDikec! Good catch — |
angelburgosrosado
pushed a commit
to angelburgosrosado/hermes-agent
that referenced
this pull request
Apr 27, 2026
…uth file path in status output Authored by PercyDikec. Fixes NousResearch#447. The status display used codex_status.get('auth_file') but get_codex_auth_status() in auth.py returns the path under 'auth_store' (line 1220). This one-char key mismatch silently dropped the auth file path from 'hermes status'.
02356abc
pushed a commit
to 02356abc/hermes-agent
that referenced
this pull request
May 14, 2026
…uth file path in status output Authored by PercyDikec. Fixes NousResearch#447. The status display used codex_status.get('auth_file') but get_codex_auth_status() in auth.py returns the path under 'auth_store' (line 1220). This one-char key mismatch silently dropped the auth file path from 'hermes status'.
karlligamesvc-spec
added a commit
to karlligamesvc-spec/hermes-agent
that referenced
this pull request
Jun 28, 2026
…ffix) (#31) The default MoA preset's reference + aggregator slots used the -APEX display names (deepseek-v4-pro-APEX / glm-5.2-APEX). The relay's per-request routing (api-relay/main.py:_select_requested_model, NousResearch#448) matches a slot's `model` against the catalog route name (enabled + plan allowed_models, case-insensitive) — so a -APEX display name never matches the catalog (glm-5.2) and silently degrades to the agent's default model, killing MoA diversity. Switch both mirrored defaults to catalog route names: - reference_models: deepseek-v4-pro + glm-5.2 + qwen3.7-max (3-model diversity) - aggregator: deepseek-v4-pro - provider stays custom:apex-nodes.com (managed relay routes per model name) Comments now flag these as relay catalog route names that MUST stay in sync with the api-relay catalog + plan allowed_models; Kael can re-tune after benchmark. glm-5.2/kimi-k2.6 are catalog-disabled and qwen3.7-max isn't in the managed catalog yet (BYOK preset), so today those two fall back to deepseek-v4-pro until their catalog rows are enabled/added. cli-config.yaml.example + hermes_cli/moa_config.py kept mirrored. MoA pytest (test_moa_config / test_moa_loop_mode / test_moa_command) green. Co-authored-by: karlligamesvc-spec <270151505+karlligamesvc-spec@users.noreply.github.com> Co-authored-by: Claude Opus 4.8 <noreply@anthropic.com>
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
…uth file path in status output Authored by PercyDikec. Fixes NousResearch#447. The status display used codex_status.get('auth_file') but get_codex_auth_status() in auth.py returns the path under 'auth_store' (line 1220). This one-char key mismatch silently dropped the auth file path from 'hermes status'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
hermes statusreads the Codex auth file path withcodex_status.get("auth_file"), butget_codex_auth_status()inauth.pyreturns it under"auth_store". This means the auth file path is silently dropped and never shown to the user.Changed
"auth_file"to"auth_store"instatus.pyto match the key returned byauth.py.Related Issue
Fixes #447
Type of Change
Changes Made
hermes_cli/status.py: Changedcodex_status.get("auth_file")tocodex_status.get("auth_store")(line 131) to match the dict key fromget_codex_auth_status()inauth.py(line 1220)How to Test
status.pyline 131 withauth.pyline 1220 - the dict key now matcheshermes statusafter logging in to Codex - "Auth file:" line should now appearChecklist
Code
Documentation & Housekeeping