fix(telegram): refresh topic binding before auto-title after compression - #44781
Closed
McHersheys wants to merge 1 commit into
Closed
fix(telegram): refresh topic binding before auto-title after compression#44781McHersheys wants to merge 1 commit into
McHersheys wants to merge 1 commit into
Conversation
Contributor
|
Verified this PR — the fix correctly refreshes the Telegram topic binding before Checklist applied:
|
Contributor
|
Closing as superseded by the compression split fix that landed in PR #45529: That merged change now syncs compression-created session IDs before failed/no-final-response paths can return, resets the history offset for split failures, and refreshes the Telegram topic binding on the rotated child session. Thanks for the fix/report — the payload here is now covered on current main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44769.
When a Telegram DM topic turn compresses into a child session, refresh the topic binding immediately after the split so the auto-title rename callback sees the child session instead of skipping on a stale parent binding.
Tests:
uv run pytest tests/gateway/test_telegram_topic_mode.py -quv run ruff check gateway/run.py tests/gateway/test_telegram_topic_mode.py