feat(cli): persist resolved approval/clarify prompts in scrollback - #44702
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolved approval and clarify prompts now leave a one-line record in CLI scrollback, so the question and the decision survive the panel repaint.
Requested on Discord: modal prompt panels (dangerous-command approval, clarify) live in the prompt_toolkit layout and vanish on the next repaint — afterwards there is no trace of what was asked or what the user chose.
Changes
cli.py: new_persist_prompt_summary()helper; called on approval resolution (⚠ Approval: <command> → allowed for session / denied / …) and clarify resolution (? Clarify: <question> → <answer>). Detail/outcome whitespace-collapsed and capped at 120 chars. Timeout paths already printed their own line.cli.py+hermes_cli/config.py:display.persist_promptsconfig key (defaulttrue); setfalseto keep scrollback untouched.tests/cli/test_cli_approval_ui.py: 4 new tests — approval summary, long-command truncation, config-off suppression, clarify summary.Validation
⚠ Approval: rm -rf /tmp/scratch → allowed for session? Clarify: Pick a path? → Bdisplay.persist_prompts: falsetests/cli/test_cli_approval_ui.py: 22/22 passed.Infographic