Conversation
The inline edit composer caps height at max-h-48 but had no overflow rule, so long prompts were clipped with no way to reach the tail. Add overflow-y-auto to match the main composer editor.
eacd783 to
82a1f1f
Compare
|
Thanks for the focused desktop fix. Current main still renders the inline edit No substantive problems identified. The PR's one-class change and focused regression assertion match the confirmed failure path. The target files are unchanged from the PR base on current main, so this should be mechanically salvageable. Automated hermes-sweeper review. |
|
Thanks for this fix! It was salvaged into #86766 (cherry-picked onto current main with your authorship preserved in the commit history) and is now merged. Closing since the work has landed. |
Symptom
When you click a previous prompt in Hermes Desktop, the bubble briefly expands to show the full text, then snaps back to a clipped view — and you can't scroll within the editor, so the tail of a long prompt becomes unreachable.
Root cause
Clicking a read-only user bubble opens the inline edit composer. Its
contentEditableeditor (apps/desktop/src/components/assistant-ui/thread.tsx) caps its height atmax-h-48but had no overflow rule, and its container isoverflow-hidden. So a prompt taller than the cap is clipped with no scrollbar.The "expands then shrinks" flash is the read-only bubble lifting its 2-line
sticky-human-clampon focus right before the edit composer mounts and clips.The main chat composer's editor (
apps/desktop/src/app/chat/composer/index.tsx) already pairs its height cap withoverflow-y-auto; the edit composer simply missed it.Fix
Add
overflow-y-autoto the edit composer editor — one class, matching the main composer. Overflow now scrolls within the capped height instead of being hidden.Test
Added a regression to
user-message-edit.test.tsxasserting the edit composer editor keeps both the height cap (max-h-48) and a scroll affordance (overflow-y-auto). Confirmed RED before the fix, GREEN after.Verification