fix(auth): share xAI OAuth root store across profiles - #44604
Closed
tontoko wants to merge 1 commit into
Closed
Conversation
Contributor
|
Verification review — reviewed this PR's diff in detail (auth store isolation for xAI OAuth across named profiles). What I checked:
Verdict: Clean. The read/write path asymmetry (global-canonical for xai-oauth, profile-local for everything else) is consistent across all 6 touch points. Lock scoping is correct. |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
scripts/run_tests.sh tests/agent/test_credential_pool.py tests/hermes_cli/test_auth_profile_fallback.py tests/hermes_cli/test_auth_xai_oauth_provider.py tests/hermes_cli/test_xai_oauth_pkce_token_exchange.py tests/run_agent/test_codex_xai_oauth_recovery.py tests/agent/test_auxiliary_client_xai_oauth_recovery.py(252 passed)test-writer,frontend-engineer, andcode-reviewer: xAI OAuth status logged in and runtime credential resolution used/home/hirakitomohiko/.hermes/auth.jsonfor both read/write routing. Token values were not printed.Source kanban follow-through: t_ada9abd3 / t_0276f271.