Skip to content

fix(ui-tui): stabilize embedded dashboard chat gateway #44528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
austinpickett merged 1 commit into from
Jun 11, 2026
Merged

fix(ui-tui): stabilize embedded dashboard chat gateway #44528

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion nix/lib.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ let

# Single npm deps fetch from the workspace root lockfile.
# All workspace packages share this derivation.
npmDepsHash = "sha256-jN6rD+vVhTCWz3lFZzlmFYXmcMRPTtYWy3XVSiDYbvM=";
npmDepsHash = "sha256-BfTSh6J2VZ/07tq2DYnKgUViZCgRhW1sC2uj18H65SE=";

npmDeps = pkgs.fetchNpmDeps {
inherit src;
Expand Down
77 changes: 67 additions & 10 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ui-tui/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"ink-text-input": "^6.0.0",
"nanostores": "^1.2.0",
"react": "^19.2.4",
"undici": "^6.25.0",
"unicode-animations": "^1.0.3"
},
"devDependencies": {
Expand Down
16 changes: 14 additions & 2 deletions ui-tui/src/__tests__/createGatewayEventHandler.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -658,6 +658,17 @@ describe('createGatewayEventHandler', () => {
})
})

it('does not fetch config while constructing the gateway event handler', () => {
const appended: Msg[] = []
const ctx = buildCtx(appended)

ctx.gateway.rpc = vi.fn(async () => null)

createGatewayEventHandler(ctx)

expect(ctx.gateway.rpc).not.toHaveBeenCalled()
})

it('on gateway.ready with no STARTUP_RESUME_ID and auto_resume off, forges a new session', async () => {
const appended: Msg[] = []
const newSession = vi.fn()
Expand Down Expand Up @@ -1020,8 +1031,9 @@ describe('createGatewayEventHandler', () => {
)
const onEvent = createGatewayEventHandler(ctx)

// Eager config fetch fires at creation; let it resolve before any spawn
// (mirrors real usage — config lands well before the first delegation).
// Config fetch starts once the gateway is ready; let it resolve before any
// spawn (mirrors real usage — config lands well before first delegation).
onEvent({ payload: {}, type: 'gateway.ready' } as any)
await Promise.resolve()
await Promise.resolve()

Expand Down
Loading
Loading