fix(termux): align manual psutil install with supported installer - #44390
fix(termux): align manual psutil install with supported installer#44390lifuyue wants to merge 1 commit into
Conversation
|
Hi @alt-glitch, sorry for the ping. I saw your triage note on #31415 and used it to keep this PR scoped to the remaining manual-guide gap rather than changing the installer path again. The PR body already has the reproduction notes and targeted tests, so I will not repeat those here. When you have a chance, would you mind sanity-checking whether this matches the issue scope you called out, or pointing me to a better reviewer for this Termux/install docs follow-up? Thank you. |
|
Thanks for narrowing this to the remaining manual-install gap. Current main still sends the manual Termux path directly to The proposed English and zh-Hans documentation updates align the manual path with that implementation, and the added tests assert the important ordering invariant in both guides. The For salvage: Automated hermes-sweeper review. |
4a1f9b5 to
3838b69
Compare
|
Thanks for the review. I’ve rebased the PR onto the latest main, and the patch now passes git apply --check cleanly for all three files. The targeted documentation tests also pass (2 passed). The changes remain scoped to the Termux manual-install documentation gap. |
Problem
The supported Termux installer prebuilds Hermes' Android psutil compatibility shim before installing the Python package, but the documented manual-install path previously went directly to
pip install -e '.[termux]'.On a fresh Android environment, that difference causes the manual path to fail when upstream psutil rejects
sys.platform == "android". This PR closes that Termux compatibility gap by aligning the documented manual workflow with the behavior already implemented by the supported installer; it is not only a documentation clarification.What Changed
python scripts/install_psutil_android.pybeforepip install -e '.[termux]'jiter/maturinon 32-bitarmv8lTermux devices usingCARGO_BUILD_TARGETReproduction
On current
main, I reproduced the psutil failure path by extracting psutil 7.2.2 from the pinned sdist and running its metadata step withsys.platformforced toandroid. The unpatched sdist exits with:Applying Hermes' existing
prepare_patched_psutil_sdist()shim moves past that original rejection point. This confirms that the missing shim step in the manual workflow is the broken path reported in #31415.Validation
After rebasing onto the latest
main, the focused documentation regression tests pass (2 passed), and the complete PR patch passesgit apply --checkcleanly against a freshmainworktree.Fixes #31415