Skip to content

fix(agent): gate coding-posture skill-index demotion behind the opt-in focus mode - #44387

Merged
teknium1 merged 1 commit into
mainfrom
fix/skill-compacting-focus-gate
Jun 11, 2026
Merged

fix(agent): gate coding-posture skill-index demotion behind the opt-in focus mode#44387
teknium1 merged 1 commit into
mainfrom
fix/skill-compacting-focus-gate

Conversation

@teknium1

Copy link
Copy Markdown
Contributor

Summary

The coding posture's skill-index demotion now only applies under the opt-in focus mode — the default auto posture (and on) never touch the skill index.

#43316/#44342 demoted non-coding skill categories to names-only under the default posture, silently changing the prompt's skill index for every user sitting in a git repo. Index changes are now opt-in, matching the gating contract of the focus toolset collapse. Focus semantics are unchanged: demoted, never hidden; deny-list keeps coding-adjacent and unknown/custom categories at full entries.

Changes

  • agent/coding_context.py: RuntimeMode.compact_skill_categories() returns empty unless config_mode == "focus"; module/profile docs updated.
  • agent/system_prompt.py, hermes_cli/config.py: comments updated to match.
  • tests/agent/test_coding_context.py: asserts auto/on demote nothing, focus demotes the deny list.

Validation

Before After
auto / on skill index non-coding categories names-only untouched
focus skill index names-only demotion names-only demotion (unchanged)
test_coding_context + prompt_builder + system_prompt 183 passed

E2E (real imports, temp HERMES_HOME, real git repo): auto/on → frozenset(); focus → deny list active, autonomous-ai-agents/games never demoted; messaging platforms never demote even on focus.

Infographic

skill-index-focus-gate

The coding posture's names-only demotion of non-coding skill categories
(#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
@github-actions

Copy link
Copy Markdown
Contributor

🔎 Lint report: fix/skill-compacting-focus-gate vs origin/main

ruff

Total: 0 on HEAD, 0 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 0 pre-existing issues carried over.

ty (type checker)

Total: 10719 on HEAD, 10719 on base (➖ 0)

🆕 New issues: none

✅ Fixed issues: none

Unchanged: 5611 pre-existing issues carried over.

Diagnostics are surfaced as warnings — this check never fails the build.

@teknium1
teknium1 merged commit 4d6a133 into main Jun 11, 2026
28 checks passed
@teknium1
teknium1 deleted the fix/skill-compacting-focus-gate branch June 11, 2026 17:01
alt-glitch pushed a commit that referenced this pull request Jun 14, 2026
…44387)

The coding posture's names-only demotion of non-coding skill categories
(#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
AIalliAI pushed a commit to AIalliAI/Hermes that referenced this pull request Jun 14, 2026
…ousResearch#44387)

The coding posture's names-only demotion of non-coding skill categories
(NousResearch#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
T02200059 pushed a commit to T02200059/hermes-agent that referenced this pull request Jun 18, 2026
…ousResearch#44387)

The coding posture's names-only demotion of non-coding skill categories
(NousResearch#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
waefrebeorn pushed a commit to waefrebeorn/slermes that referenced this pull request Jul 2, 2026
…ousResearch#44387)

The coding posture's names-only demotion of non-coding skill categories
(NousResearch#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
santhreal pushed a commit to santhreal/hermes-agent that referenced this pull request Jul 13, 2026
…ousResearch#44387)

The coding posture's names-only demotion of non-coding skill categories
(NousResearch#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
donbowman pushed a commit to donbowman/hermes-agent that referenced this pull request Jul 13, 2026
…ousResearch#44387)

The coding posture's names-only demotion of non-coding skill categories
(NousResearch#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
Gravezzz pushed a commit to Gravezzz/hermes-agent that referenced this pull request Jul 21, 2026
…ousResearch#44387)

The coding posture's names-only demotion of non-coding skill categories
(NousResearch#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
leewenjie pushed a commit to leewenjie/hermes-agent that referenced this pull request Aug 7, 2026
…ousResearch#44387)

The coding posture's names-only demotion of non-coding skill categories
(NousResearch#44342) applied under the default auto mode, silently changing the skill
index for every user in a git repo. Index changes must be opt-in: demotion
now only fires under agent.coding_context=focus, alongside the toolset
collapse. auto/on leave the skill index untouched; focus semantics are
unchanged (demoted, never hidden; deny-list keeps coding-adjacent and
custom categories at full entries).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant