fix(docs): target installer venv in voice extra install command - #44367
Closed
liuhao1024 wants to merge 1 commit into
Closed
fix(docs): target installer venv in voice extra install command#44367liuhao1024 wants to merge 1 commit into
liuhao1024 wants to merge 1 commit into
Conversation
The quickstart voice-mode section used `uv pip install -e ".[voice]"` which fails on a fresh curl-installed setup because no virtual environment is active. Use `--python ./venv/bin/python` to target the installer-created venv explicitly, matching the curl installer layout. Fixes NousResearch#44364
tonydwb
approved these changes
Jun 11, 2026
tonydwb
left a comment
There was a problem hiding this comment.
Code Review Summary
Verdict: Approved
Summary
Fixes the voice extra install command to target the installer venv instead of the runtime venv.
Review
- Correct path fix for the voice extra installation instructions.
- No security concerns.
Reviewed by Hermes Agent (batch cron)
Contributor
|
Merged into main via consolidated salvage PR #73520 (merge Your contribution is credited to you in git history. Thank you! Closing this PR as merged-via-salvage. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes the voice-mode extra install command in the quickstart docs to target the installer-created virtual environment explicitly, preventing failures on fresh curl-installed setups where no venv is active.
Related Issue
Fixes #44364
Type of Change
Changes Made
website/docs/getting-started/quickstart.md: Changeduv pip install -e ".[voice]"touv pip install --python ./venv/bin/python -e ".[voice]"so it targets the installer-created venv without requiring manual activation.website/i18n/zh-Hans/docusaurus-plugin-content-docs/current/getting-started/quickstart.md: Same fix for the Chinese localization.How to Test
cd ~/.hermes/hermes-agentuv pip install --python ./venv/bin/python -e ".[voice]"— it should install successfullyfaster-whisper,sounddevice, andnumpyare installed in the venv:./venv/bin/python -c "import faster_whisper; print('OK')"Checklist
Code
fix(scope):,feat(scope):, etc.)pytest tests/ -qand all tests passDocumentation & Housekeeping
docs/, docstrings)cli-config.yaml.exampleif I added/changed config keys — N/ACONTRIBUTING.mdorAGENTS.mdif I changed architecture or workflows — N/ACode Intelligence
website/docs/getting-started/quickstart.md(voice-mode section, line 267-275)uv pip installwithout--pythonpattern exists in MCP and ACP sections of the same file, but those are out of scope for this issue