fix(cli): only pad short responses to avoid pushing content off-screen - #4436
Closed
gnanam1990 wants to merge 1 commit into
Closed
fix(cli): only pad short responses to avoid pushing content off-screen#4436gnanam1990 wants to merge 1 commit into
gnanam1990 wants to merge 1 commit into
Conversation
Unconditional half-terminal-height padding after every response (added in NousResearch#4359, removed in NousResearch#4412) caused long responses to be scrolled out of view. Re-introduce the padding but gate it on response length: padding is only applied when the response is shorter than half the terminal height, and only enough lines are added to fill the remaining gap. Fixes: NousResearch#4421 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
Thanks for the contribution @gnanam1990! This is a thoughtful approach to gating the padding on response length. However, the underlying issue (#4421) was already resolved by PR #4412 (merged ~20 minutes before the issue was filed). That PR removed the per-response padding entirely and replaced it with a one-time startup scroll that pins the TUI to the bottom of the terminal. The padding code from #4359 that #4421 describes no longer exists on current Closing as the root cause is already addressed. Appreciate you taking the time! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_pad - _resp_lines) so no unnecessary blank lines are addedHow it works
Fixes #4421
Test plan
python3 -m py_compile cli.pypasses with no errors🤖 Generated with Claude Code