fix(tui): decode TUI startup subprocess output as utf-8 on Windows - #44328
Merged
Conversation
Contributor
🔎 Lint report:
|
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Windows
hermes --tuino longer crashes withUnicodeDecodeError: 'charmap' codec can't decode byte 0x8fwhen npm/node emit bytes outside the active ANSI code page — all TUI launcher subprocess captures now decode as UTF-8 with replacement.Salvage of #43790 by @helix4u (authorship preserved via cherry-pick), plus one sibling fix.
Changes
hermes_cli/main.py:encoding="utf-8", errors="replace"on the node bootstrap probe, TUInpm install, dev prebuild, andnpm run buildcaptures (contributor)hermes_cli/main.py: same fix for the WhatsApp bridgenpm installcapture — same bug class, audited via subprocess-capture sweep (follow-up)tests/hermes_cli/test_tui_npm_install.py: asserts the decode policy on the npm capturesValidation
pytest tests/hermes_cli/test_tui_npm_install.py0x8fbyte with the new decode argscapture_output+text=Truesites in main.pyInfographic