fix(dashboard): Anthropic API Key status checks ANTHROPIC_API_KEY; hide deprecated tool-progress env vars - #44286
Merged
Merged
Conversation
… Claude Code creds; hide deprecated tool-progress env vars Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
Contributor
🔎 Lint report:
|
alt-glitch
pushed a commit
that referenced
this pull request
Jun 14, 2026
… Claude Code creds; hide deprecated tool-progress env vars (#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
AIalliAI
pushed a commit
to AIalliAI/Hermes
that referenced
this pull request
Jun 14, 2026
… Claude Code creds; hide deprecated tool-progress env vars (NousResearch#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
xyshanren
pushed a commit
to xyshanren/hermes-agent-cn
that referenced
this pull request
Jun 17, 2026
… Claude Code creds; hide deprecated tool-progress env vars (NousResearch#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged). (cherry picked from commit 9c051f5)
T02200059
pushed a commit
to T02200059/hermes-agent
that referenced
this pull request
Jun 18, 2026
… Claude Code creds; hide deprecated tool-progress env vars (NousResearch#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
waefrebeorn
pushed a commit
to waefrebeorn/slermes
that referenced
this pull request
Jul 2, 2026
… Claude Code creds; hide deprecated tool-progress env vars (NousResearch#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
santhreal
pushed a commit
to santhreal/hermes-agent
that referenced
this pull request
Jul 13, 2026
… Claude Code creds; hide deprecated tool-progress env vars (NousResearch#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
donbowman
pushed a commit
to donbowman/hermes-agent
that referenced
this pull request
Jul 13, 2026
… Claude Code creds; hide deprecated tool-progress env vars (NousResearch#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
Gravezzz
pushed a commit
to Gravezzz/hermes-agent
that referenced
this pull request
Jul 21, 2026
… Claude Code creds; hide deprecated tool-progress env vars (NousResearch#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
leewenjie
pushed a commit
to leewenjie/hermes-agent
that referenced
this pull request
Aug 7, 2026
… Claude Code creds; hide deprecated tool-progress env vars (NousResearch#44286) Two dashboard fixes: 1. The 'Anthropic API Key' OAuth catalog entry's status fn read ~/.claude/.credentials.json (which has its own dedicated claude-code entry) and never checked ANTHROPIC_API_KEY at all. It now checks the Hermes PKCE file, then the registry env-var order (ANTHROPIC_API_KEY -> ANTHROPIC_TOKEN -> CLAUDE_CODE_OAUTH_TOKEN) via get_env_value, so keys from .env, the shell, or Bitwarden (injected into the process env by load_hermes_dotenv) are all reported, with a '(from Bitwarden)' source suffix when applicable. 2. Deprecated HERMES_TOOL_PROGRESS / HERMES_TOOL_PROGRESS_MODE removed from OPTIONAL_ENV_VARS so the keys page and setup checklists stop offering them. Moved to _EXTRA_ENV_KEYS so .env sanitization and reload_env still recognize them for existing users (gateway back-compat fallback unchanged).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard's "Anthropic API Key" entry now reports the actual API key (env/.env/Bitwarden) instead of hijacking Claude Code's
~/.claude/.credentials.json, and the keys page stops listing the deprecatedHERMES_TOOL_PROGRESS*env vars.Changes
hermes_cli/web_server.py:_anthropic_oauth_status()no longer reads Claude Code credentials (that source has its own dedicatedclaude-codecatalog entry — it was double-reported and shadowed a real key). Env check now followsPROVIDER_REGISTRY["anthropic"].api_key_env_varsorder (ANTHROPIC_API_KEY→ANTHROPIC_TOKEN→CLAUDE_CODE_OAUTH_TOKEN) viaget_env_value, which covers Bitwarden-injected secrets; the source label gets a "(from Bitwarden)" suffix viaformat_secret_source_suffix. Hermes PKCE file still wins (it's what this entry's Connect button writes).hermes_cli/config.py: removed deprecatedHERMES_TOOL_PROGRESS/HERMES_TOOL_PROGRESS_MODEfromOPTIONAL_ENV_VARS(feeds the dashboard keys page + setup checklists); added them to_EXTRA_ENV_KEYSso.envsanitization andreload_envstill recognize them. Gateway back-compat fallback untouched.Validation
ANTHROPIC_API_KEYreportedANTHROPIC_API_KEY (from Bitwarden)E2E (real imports, temp HERMES_HOME): 6 scenarios pass (empty / api-key / bws label / token fallback / PKCE precedence / reload_env cleanup). Targeted tests:
tests/hermes_cli/test_web_server.py+tests/tools/test_local_env_blocklist.py— 294 passed.Infographic