fix(agent): skip OpenAI client rebuild for Anthropic-mode providers (#44006) - #44148
Closed
kyssta-exe wants to merge 1 commit into
Closed
fix(agent): skip OpenAI client rebuild for Anthropic-mode providers (#44006)#44148kyssta-exe wants to merge 1 commit into
kyssta-exe wants to merge 1 commit into
Conversation
Collaborator
Contributor
|
Code review: clean ✅ The early-return guard in
No issues found. |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #44006. Skip the OpenAI client rebuild in _replace_primary_openai_client when the provider uses the Anthropic adapter (e.g. minimax). These providers have client=None and _client_kwargs={}; attempting to rebuild would always fail with 'api_key must be set', masking the real retry logic and causing stream timeouts to drop the entire response.