fix(cli): initialize ctx_len before compact banner path - #4409
Closed
el-analista wants to merge 1 commit into
Closed
fix(cli): initialize ctx_len before compact banner path#4409el-analista wants to merge 1 commit into
el-analista wants to merge 1 commit into
Conversation
ctx_len was only assigned inside the else (non-compact) branch but referenced unconditionally after the if/else, causing an UnboundLocalError when the terminal is narrow or --compact is set.
el-analista
marked this pull request as ready for review
April 1, 2026 07:21
Contributor
|
Fixed in PR #4411, which cherry-picked the implementation from #4334. Thanks for the contribution @el-analista! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ctx_lenwas only assigned inside theelse(non-compact) branch ofshow_banner()but referenced unconditionally after theif/else, causingUnboundLocalErrorwhen the terminal is narrow or--compactis set.ctx_len = Nonebefore the branch so it's always initialized.Test plan
hermesin a terminal narrower than 80 columns (triggers compact banner)hermes --compactUnboundLocalErrorcrash on startup