Skip to content

Fix _add_path_candidate crash on ~user expanduser() RuntimeError #43970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gtyler wants to merge 1 commit into from
+4 −1
Closed

Fix _add_path_candidate crash on ~user expanduser() RuntimeError #43970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion agent/subdirectory_hints.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,10 @@ def _add_path_candidate(self, raw_path: str, candidates: Set[Path]):
if parent == p:
break # filesystem root
p = parent
except (OSError, ValueError):
except (OSError, ValueError, RuntimeError):
# RuntimeError covers Path.expanduser() on a "~user" token whose
# user is not a real account ("Could not determine home directory.").
# The hint walk is best-effort, so a bad path is skipped, never fatal.
pass

def _extract_paths_from_command(self, cmd: str, candidates: Set[Path]):
Expand Down