Fix UnboundLocalError in show_banner() for compact mode - #4392
Closed
andyg5000-agent wants to merge 1 commit into
Closed
Fix UnboundLocalError in show_banner() for compact mode#4392andyg5000-agent wants to merge 1 commit into
andyg5000-agent wants to merge 1 commit into
Conversation
The ctx_len variable was only defined inside the else block when use_compact=False, but accessed unconditionally on line 2201 for the context length warning. This caused a crash when using compact banner mode. Fix: Move ctx_len initialization before the if/else block so it is always defined regardless of banner style.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a bug where Hermes CLI crashes with UnboundLocalError when using compact banner mode.